Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. #51685

Merged
auto-submit merged 5 commits into from
Mar 27, 2024
Merged

Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. #51685

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d891112
Fail pre-submit during a negative image digest.
matanlurey Mar 26, 2024
448ac65
Add more to the message.
matanlurey Mar 26, 2024
9880f80
Format.
matanlurey Mar 26, 2024
94b82a4
Update testing/skia_gold_client/test/skia_gold_client_test.dart
matanlurey Mar 26, 2024
4ed1878
++
matanlurey Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update testing/skia_gold_client/test/skia_gold_client_test.dart 
Co-authored-by: gaaclarke <[email protected]>
  • Loading branch information
@matanlurey @gaaclarke
matanlurey and gaaclarke authored Mar 26, 2024
commit 94b82a4551870d1801b47fe8dbd61fc563c48106
2 changes: 1 addition & 1 deletion testing/skia_gold_client/test/skia_gold_client_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ void main() {
);
fail('addImg should fail due to an unapproved image');
} on SkiaGoldProcessError catch (error) {
expect(error.message, contains('Skia Gold received an unapproved image'));
expect(error.message, contains('Skia Gold received an unapproved image.'));
expect(error.stdout, 'stdout-text');
expect(error.stderr, 'stderr-text');
expect(error.command.join(' '), contains('imgtest add'));
Expand Down