[local_auth_android] Fix Android lint warnings #3764
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,13 +31,13 @@ android { | |
|
|
||
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_1_8 | ||
| targetCompatibility JavaVersion.VERSION_1_8 | ||
|
Contributor
Author
There was a problem hiding this comment. I changed it because it was set in the build.gradle of other pacakges. Now that I think about it, it's an unrelated change, so I think I'll change it back.
Collaborator
There was a problem hiding this comment. Adding it is also a no-op (which is why I didn't add it when I added
Collaborator
There was a problem hiding this comment. Setting the record straight since I just learned that this is wrong: it's a no-op for some AGP (or maybe Gradle?) versions. For older versions leaving it out causes flutter/flutter#125482 But I'll be adding this (and enforcement that it's there) in a separate PR. |
||
| } | ||
|
|
||
| lintOptions { | ||
| checkAllWarnings true | ||
| warningsAsErrors true | ||
| disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' | ||
| } | ||
|
|
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, maybe something linking the lint warnings and unused resources: