Skip to content

[video_player] Move iOS/macOS to per-player-instance Pigeon APIs #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Jul 8, 2025
Merged

[video_player] Move iOS/macOS to per-player-instance Pigeon APIs #9529

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9604dd
Implement per-instance channels
stuartmorgan-g Jun 28, 2025
1963bb3
Simplify tests
stuartmorgan-g Jun 30, 2025
3f7993a
Version bump
stuartmorgan-g Jun 30, 2025
fc05c2d
Revert project automigrations
stuartmorgan-g Jun 30, 2025
7ecdc9a
Merge branch 'main' into video-player-avfoundation-dart-player-instance
stuartmorgan-g Jul 7, 2025
a3d65e1
Fix unit test update copypasta
stuartmorgan-g Jul 7, 2025
765f9bf
Fix podspec-check warnings
stuartmorgan-g Jul 7, 2025
748d9aa
Rename away from 'api'
stuartmorgan-g Jul 7, 2025
e1f6065
Fix macOS compilation warnings
stuartmorgan-g Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unit test update copypasta
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jul 7, 2025
commit a3d65e1a097e0ab5b267d23b48d78f9ff2bc662b
2 changes: 1 addition & 1 deletion packages/video_player/video_player_avfoundation/test/avfoundation_video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ void main() {
final VerificationResult verification = verify(api.create(captureAny));
final CreationOptions creationOptions =
verification.captured[0] as CreationOptions;
expect(creationOptions.viewType, PlatformVideoViewType.platformView);
expect(creationOptions.viewType, PlatformVideoViewType.textureView);
expect(playerId, newPlayerId);
expect(player.playerViewStates[newPlayerId],
const VideoPlayerTextureViewState(textureId: newPlayerId));
Expand Down