Skip to content

[video_player] Move iOS/macOS to per-player-instance Pigeon APIs #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 9 commits into from
Jul 8, 2025
Merged

[video_player] Move iOS/macOS to per-player-instance Pigeon APIs #9529

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9604dd
Implement per-instance channels
stuartmorgan-g Jun 28, 2025
1963bb3
Simplify tests
stuartmorgan-g Jun 30, 2025
3f7993a
Version bump
stuartmorgan-g Jun 30, 2025
fc05c2d
Revert project automigrations
stuartmorgan-g Jun 30, 2025
7ecdc9a
Merge branch 'main' into video-player-avfoundation-dart-player-instance
stuartmorgan-g Jul 7, 2025
a3d65e1
Fix unit test update copypasta
stuartmorgan-g Jul 7, 2025
765f9bf
Fix podspec-check warnings
stuartmorgan-g Jul 7, 2025
748d9aa
Rename away from 'api'
stuartmorgan-g Jul 7, 2025
e1f6065
Fix macOS compilation warnings
stuartmorgan-g Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix macOS compilation warnings
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed Jul 8, 2025
commit e1f606544eb6e0a57f7b00f69a46ba271c95c85a
48 changes: 25 additions & 23 deletions packages/video_player/video_player_avfoundation/darwin/RunnerTests/VideoPlayerTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,13 +603,11 @@ - (void)testSeekToleranceWhenNotSeekingToEnd {
StubAVPlayer *stubAVPlayer = [[StubAVPlayer alloc] init];
StubFVPAVFactory *stubAVFactory = [[StubFVPAVFactory alloc] initWithPlayer:stubAVPlayer
output:nil];
FVPVideoPlayer *player = [[FVPVideoPlayer alloc]
initWithURL:
[NSURL
URLWithString:@"https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4"]
httpHeaders:@{}
avFactory:stubAVFactory
viewProvider:[[StubViewProvider alloc] initWithView:nil]];
FVPVideoPlayer *player =
[[FVPVideoPlayer alloc] initWithURL:self.mp4TestURL
httpHeaders:@{}
avFactory:stubAVFactory
viewProvider:[[StubViewProvider alloc] initWithView:nil]];

XCTestExpectation *seekExpectation =
[self expectationWithDescription:@"seekTo has zero tolerance when seeking not to end"];
Expand All @@ -627,13 +625,11 @@ - (void)testSeekToleranceWhenSeekingToEnd {
StubAVPlayer *stubAVPlayer = [[StubAVPlayer alloc] init];
StubFVPAVFactory *stubAVFactory = [[StubFVPAVFactory alloc] initWithPlayer:stubAVPlayer
output:nil];
FVPVideoPlayer *player = [[FVPVideoPlayer alloc]
initWithURL:
[NSURL
URLWithString:@"https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4"]
httpHeaders:@{}
avFactory:stubAVFactory
viewProvider:[[StubViewProvider alloc] initWithView:nil]];
FVPVideoPlayer *player =
[[FVPVideoPlayer alloc] initWithURL:self.mp4TestURL
httpHeaders:@{}
avFactory:stubAVFactory
viewProvider:[[StubViewProvider alloc] initWithView:nil]];

XCTestExpectation *seekExpectation =
[self expectationWithDescription:@"seekTo has non-zero tolerance when seeking to end"];
Expand All @@ -649,9 +645,11 @@ - (void)testSeekToleranceWhenSeekingToEnd {

/// Sanity checks a video player playing the given URL with the actual AVPlayer. This is essentially
/// a mini integration test of the player component.
- (NSDictionary<NSString *, id> *)sanityTestURI:(NSString *)uri {
- (NSDictionary<NSString *, id> *)sanityTestURI:(NSString *)testURI {
NSURL *testURL = [NSURL URLWithString:testURI];
XCTAssertNotNil(testURL);
FVPVideoPlayer *player =
[[FVPVideoPlayer alloc] initWithURL:[NSURL URLWithString:uri]
[[FVPVideoPlayer alloc] initWithURL:testURL
httpHeaders:@{}
avFactory:[[FVPDefaultAVFactory alloc] init]
viewProvider:[[StubViewProvider alloc] initWithView:nil]];
Expand Down Expand Up @@ -864,13 +862,11 @@ - (void)testFailedToLoadVideoEventShouldBeAlwaysSent {
}

- (void)testUpdatePlayingStateShouldNotResetRate {
FVPVideoPlayer *player = [[FVPVideoPlayer alloc]
initWithURL:
[NSURL
URLWithString:@"https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4"]
httpHeaders:@{}
avFactory:[[StubFVPAVFactory alloc] initWithPlayer:nil output:nil]
viewProvider:[[StubViewProvider alloc] initWithView:nil]];
FVPVideoPlayer *player =
[[FVPVideoPlayer alloc] initWithURL:self.mp4TestURL
httpHeaders:@{}
avFactory:[[StubFVPAVFactory alloc] initWithPlayer:nil output:nil]
viewProvider:[[StubViewProvider alloc] initWithView:nil]];

XCTestExpectation *initializedExpectation = [self expectationWithDescription:@"initialized"];
[player onListenWithArguments:nil
Expand Down Expand Up @@ -1038,4 +1034,10 @@ - (void)validateTransformFixForOrientation:(UIImageOrientation)orientation {
}
#endif

/// Returns a test URL for creating a player from a network source.
- (nonnull NSURL *)mp4TestURL {
return (NSURL *_Nonnull)[NSURL
URLWithString:@"https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4"];
}

@end