Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: renable no floating promises
  • Loading branch information
logaretm committed Mar 10, 2026
commit b1d889a78725db030ed8695e679feabe026c3191
3 changes: 1 addition & 2 deletions .oxlintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"typescript/consistent-type-imports": "error",
"typescript/no-unnecessary-type-assertion": "error",
"typescript/prefer-for-of": "error",
// "typescript/no-floating-promises": ["error", { "ignoreVoid": false }],
"typescript/no-floating-promises": ["error", { "ignoreVoid": true }],
"typescript/no-dynamic-delete": "error",
// "typescript/no-unsafe-member-access": "error",
"typescript/unbound-method": "error",
Expand All @@ -70,7 +70,6 @@

// === FIXME: Rules to turn back as error ===
"typescript/prefer-optional-chain": "warn",
"typescript/no-floating-promises": "warn",
"typescript/no-unsafe-member-access": "warn"
}
},
Expand Down
1 change: 1 addition & 0 deletions packages/deno/src/utils/streaming.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ function monitorStream(
onDone: () => void,
): ReadableStream<Uint8Array<ArrayBufferLike>> {
const reader = stream.getReader();
// oxlint-disable-next-line typescript/no-floating-promises
reader.closed.finally(() => onDone());
return new ReadableStream({
Comment thread
logaretm marked this conversation as resolved.
async start(controller) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ function trackLazyRouteLoad(span: Span, promise: Promise<unknown>): void {
promises.add(promise);

// Clean up when promise resolves/rejects
// oxlint-disable-next-line typescript/no-floating-promises
promise.finally(() => {
const currentPromises = pendingLazyRouteLoads.get(span);
Comment thread
logaretm marked this conversation as resolved.
if (currentPromises) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export function handleHistorySpanListener(replay: ReplayContainer): (handlerData
replay.triggerUserActivity();

replay.addUpdate(() => {
// oxlint-disable-next-line typescript/no-floating-promises
createPerformanceSpans(replay, [result]);
// Returning false to flush
return false;
Comment thread
logaretm marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export function addNetworkBreadcrumb(
}

replay.addUpdate(() => {
// oxlint-disable-next-line typescript/no-floating-promises
createPerformanceSpans(replay, [result]);
// Returning true will cause `addUpdate` to not flush
Comment thread
logaretm marked this conversation as resolved.
// We do not want network requests to cause a flush. This will prevent
Expand Down