Skip to content

chore(lint): Rule adjustments and fix warnings #19612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logaretm merged 22 commits into from
Mar 10, 2026
Merged

chore(lint): Rule adjustments and fix warnings #19612

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f5135e7
chore: initial config and rule setup
logaretm Feb 2, 2026
a722d54
chore: cleanup eslint
logaretm Feb 2, 2026
b1d889a
chore: renable no floating promises
logaretm Feb 19, 2026
cef9a25
chore: re-enable prefer-optional-chain
logaretm Feb 19, 2026
03031d0
chore: enable no-unsafe-member-access
logaretm Feb 19, 2026
41b258d
chore: remove unused imports
logaretm Mar 9, 2026
ab2b8d2
ref: deleted unused debugger.info method
logaretm Mar 9, 2026
355ad20
lint: remove redundant undefineds
logaretm Mar 9, 2026
7cf7e2c
chore: disable several rules
logaretm Mar 9, 2026
d840f01
lint: fix unused vars by prefixing _
logaretm Mar 9, 2026
74d86ff
lint: remove jest rules since we use vitest
logaretm Mar 9, 2026
b8f68dd
lint: fix duplicate types
logaretm Mar 9, 2026
903df65
fix: format
logaretm Mar 9, 2026
fe828c5
chore: revert nx change
logaretm Mar 9, 2026
1e954ab
lint: configure await-thenable as warn, disable in tests/dev-packages
logaretm Mar 9, 2026
e953478
lint: fix await-thenable warnings
logaretm Mar 9, 2026
d3c7bad
lint: simplify optional chaining in client and transport files
logaretm Mar 10, 2026
96a4f31
chore: remove unused jest rules configs
logaretm Mar 10, 2026
52179c4
chore: no longer needed ignore
logaretm Mar 10, 2026
3fcaf65
lint: remove unused ignores
logaretm Mar 10, 2026
dbf0ee5
lint: revert exact prop types changes
logaretm Mar 10, 2026
e3b9475
lint: remove unused error catch param
logaretm Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint: fix duplicate types
  • Loading branch information
@logaretm
logaretm committed Mar 10, 2026
commit b8f68dd210af1a07c653a4cc31a776538499c989
1 change: 0 additions & 1 deletion packages/browser-utils/src/metrics/browserMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,6 @@ type StartEventName =
| 'loadEvent';

type EndEventName =
| 'connectEnd'
Copy link
Copy Markdown
Member

@Lms24 Lms24 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Why did we remove connectEnd? It's a valid property for resource timing and we reference it below in the code. I suspect it's because this type isn't used there (?).

Copy link
Copy Markdown
Member Author

@logaretm logaretm Mar 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows up again in line 581, so its literally duplicated 😆 It's just outside the diff window

| 'domainLookupStart'
| 'domainLookupEnd'
| 'unloadEventEnd'
Expand Down
9 changes: 1 addition & 8 deletions packages/core/src/types-hoist/polymorphics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,13 @@ export interface PolymorphicEvent {
}

/** A `Request` type compatible with Node, Express, browser, etc., because everything is optional */
export type PolymorphicRequest = BaseRequest &
BrowserRequest &
NodeRequest &
ExpressRequest &
KoaRequest &
NextjsRequest;
export type PolymorphicRequest = BaseRequest & NodeRequest & ExpressRequest & KoaRequest & NextjsRequest;

type BaseRequest = {
method?: string;
url?: string;
};

type BrowserRequest = BaseRequest;

type NodeRequest = BaseRequest & {
headers?: {
[key: string]: string | string[] | undefined;
Expand Down
1 change: 1 addition & 0 deletions packages/svelte/test/components/Dummy.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import * as Sentry from '../../src/index';

// Pass options to trackComponent as props of this component
// oxlint-disable-next-line no-unassigned-vars
export let options;

Sentry.trackComponent(options);
Expand Down