chore: re-enable prefer-optional-chain

.oxlintrc.json

@@ -67,9 +67,9 @@
         "typescript/unbound-method": "error",
         "typescript/no-explicit-any": "error",
         "typescript/no-empty-function": "off",
+        "typescript/prefer-optional-chain": ["error"],
 
         // === FIXME: Rules to turn back as error ===
-        "typescript/prefer-optional-chain": "warn",
         "typescript/no-unsafe-member-access": "warn"
       }
     },
@@ -110,7 +110,8 @@
         "typescript/no-floating-promises": "off",
         "typescript/unbound-method": "off",
         "max-lines": "off",
-        "complexity": "off"
+        "complexity": "off",
+        "typescript/prefer-optional-chain": "off"
       }
     },
     {

packages/angular/src/errorhandler.ts

@@ -26,6 +26,7 @@ export interface ErrorHandlerOptions {
 function tryToUnwrapZonejsError(error: unknown): unknown | Error {
   // TODO: once Angular14 is the minimum requirement ERROR_ORIGINAL_ERROR and
   //  getOriginalError from error.ts can be used directly.
+  // oxlint-disable-next-line typescript/prefer-optional-chain
   return error && (error as { ngOriginalError: Error }).ngOriginalError
     ? (error as { ngOriginalError: Error }).ngOriginalError
     : error;
@@ -39,6 +40,7 @@ function extractHttpModuleError(error: HttpErrorResponse): string | Error {
 
   // ... or an`ErrorEvent`, which can provide us with the message but no stack...
   // guarding `ErrorEvent` against `undefined` as it's not defined in Node environments
+  // oxlint-disable-next-line typescript/prefer-optional-chain
   if (typeof ErrorEvent !== 'undefined' && error.error instanceof ErrorEvent && error.error.message) {
     return error.error.message;
   }

packages/angular/src/zone.ts

@@ -7,7 +7,7 @@ declare const Zone: any;
 // In Angular 17 and future versions, zoneless support is forthcoming.
 // Therefore, it's advisable to safely check whether the `run` function is
 // available in the `<root>` context.
-// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access typescript/prefer-optional-chain
 const isNgZoneEnabled = typeof Zone !== 'undefined' && Zone.root?.run;
 
 /**

packages/astro/src/integration/snippets.ts

@@ -59,6 +59,7 @@ const buildClientIntegrations = (options: SentryOptions): string => {
     integrations.push('Sentry.browserTracingIntegration()');
   }
 
+  /* oxlint-disable typescript/prefer-optional-chain */
   if (
     options.replaysSessionSampleRate == null ||
     options.replaysSessionSampleRate ||
@@ -67,6 +68,7 @@ const buildClientIntegrations = (options: SentryOptions): string => {
   ) {
     integrations.push('Sentry.replayIntegration()');
   }
+  /* oxlint-enable typescript/prefer-optional-chain */
 
   return integrations.join(', ');
 };

packages/browser/src/eventbuilder.ts

@@ -165,6 +165,7 @@ function getPopFirstTopFrames(ex: Error & { framesToPop?: unknown }): number {
 function isWebAssemblyException(exception: unknown): exception is WebAssembly.Exception {
   // Check for support
   // @ts-expect-error - WebAssembly.Exception is a valid class
+  // oxlint-disable-next-line typescript/prefer-optional-chain
   if (typeof WebAssembly !== 'undefined' && typeof WebAssembly.Exception !== 'undefined') {
     // @ts-expect-error - WebAssembly.Exception is a valid class
     return exception instanceof WebAssembly.Exception;

packages/browser/src/stack-parsers.ts

@@ -88,7 +88,7 @@ const chromeStackParserFn: StackLineParserFn = line => {
   const parts = chromeRegex.exec(line) as null | [string, string, string, string, string];
 
   if (parts) {
-    const isEval = parts[2] && parts[2].indexOf('eval') === 0; // start of line
+    const isEval = parts[2]?.indexOf('eval') === 0; // start of line
 
     if (isEval) {
       const subMatch = chromeEvalRegex.exec(parts[2]) as null | [string, string, string, string];

packages/browser/src/tracing/browserTracingIntegration.ts

@@ -526,8 +526,7 @@ export const browserTracingIntegration = ((options: Partial<BrowserTracingOption
       if (
         enableLongAnimationFrame &&
         GLOBAL_OBJ.PerformanceObserver &&
-        PerformanceObserver.supportedEntryTypes &&
-        PerformanceObserver.supportedEntryTypes.includes('long-animation-frame')
+        PerformanceObserver.supportedEntryTypes?.includes('long-animation-frame')
       ) {
         startTrackingLongAnimationFrames();
       } else if (enableLongTask) {

packages/core/src/client.ts

@@ -1321,6 +1321,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
           throw _makeDoNotSendEventError('An event processor returned `null`, will not send event.');
         }
 
+        // oxlint-disable-next-line typescript/prefer-optional-chain
         const isInternalException = hint.data && (hint.data as { __sentry__: boolean }).__sentry__ === true;
         if (isInternalException) {
           return prepared;

packages/core/src/integrations/mcp-server/transport.ts

@@ -105,6 +105,7 @@ export function wrapTransportSend(transport: MCPTransport, options: ResolvedMcpO
         }
 
         if (isJsonRpcResponse(message)) {
+          // oxlint-disable-next-line typescript/prefer-optional-chain
           if (message.id !== null && message.id !== undefined) {
             if (message.error) {
               captureJsonRpcErrorResponse(message.error);

packages/core/src/tracing/google-genai/index.ts

@@ -143,6 +143,7 @@ function addPrivateRequestAttributes(span: Span, params: Record<string, unknown>
 
   // config.systemInstruction: ContentUnion
   if (
+    // oxlint-disable-next-line typescript/prefer-optional-chain
     'config' in params &&
     params.config &&
     typeof params.config === 'object' &&

packages/core/src/tracing/openai/utils.ts

@@ -222,6 +222,7 @@ export function addResponsesApiAttributes(span: Span, response: OpenAIResponseOb
       // Filter for function_call type objects in the output array
       const functionCalls = responseWithOutput.output.filter(
         (item): unknown =>
+          // oxlint-disable-next-line typescript/prefer-optional-chain
           typeof item === 'object' && item !== null && (item as Record<string, unknown>).type === 'function_call',
       );
 

packages/core/src/tracing/vercel-ai/index.ts

@@ -135,7 +135,7 @@ function vercelAiEventProcessor(event: Event): Event {
 
     // Also apply to root when it is the invoke_agent pipeline
     const trace = event.contexts?.trace;
-    if (trace && trace.op === 'gen_ai.invoke_agent') {
+    if (trace?.op === 'gen_ai.invoke_agent') {
       applyAccumulatedTokens(trace, tokenAccumulator);
     }
   }

packages/core/src/utils/prepareEvent.ts

@@ -95,6 +95,7 @@ export function prepareEvent(
   ];
 
   // Skip event processors for internal exceptions to prevent recursion
+  // oxlint-disable-next-line typescript/prefer-optional-chain
   const isInternalException = hint.data && (hint.data as { __sentry__: boolean }).__sentry__ === true;
   const result = isInternalException
     ? resolvedSyncPromise(prepared)

packages/nextjs/src/client/clientNormalizationIntegration.ts

@@ -18,7 +18,7 @@ export const nextjsClientStackFrameNormalizationIntegration = defineIntegration(
       iteratee: frame => {
         if (experimentalThirdPartyOriginStackFrames) {
           // Not sure why but access to global WINDOW from @sentry/Browser causes hideous ci errors
-          // eslint-disable-next-line no-restricted-globals
+          // oxlint-disable-next-line typescript/prefer-optional-chain no-restricted-globals
           const windowOrigin = typeof window !== 'undefined' && window.location ? window.location.origin : '';
           // A filename starting with the local origin and not ending with JS is most likely JS in HTML which we do not want to rewrite
           if (frame.filename?.startsWith(windowOrigin) && !frame.filename.endsWith('.js')) {

packages/nextjs/src/common/devErrorSymbolicationEventProcessor.ts

@@ -73,6 +73,7 @@ export async function devErrorSymbolicationEventProcessor(event: Event, hint: Ev
   // Due to changes across Next.js versions, there are a million things that can go wrong here so we just try-catch the
   // entire event processor. Symbolicated stack traces are just a nice to have.
   try {
+    // oxlint-disable-next-line typescript/prefer-optional-chain
     if (hint.originalException && hint.originalException instanceof Error && hint.originalException.stack) {
       const frames = stackTraceParser.parse(hint.originalException.stack);
       const nextJsVersion = globalWithInjectedValues._sentryNextJsVersion;

packages/node-core/src/integrations/local-variables/local-variables-sync.ts

@@ -205,6 +205,7 @@ class AsyncSession implements DebugSession {
   private _unrollOther(prop: Runtime.PropertyDescriptor, vars: Variables, next: (vars: Variables) => void): void {
     if (prop.value) {
       if ('value' in prop.value) {
+        // oxlint-disable-next-line typescript/prefer-optional-chain
         if (prop.value.value === undefined || prop.value.value === null) {
           vars[prop.name] = `<${prop.value.value}>`;
         } else {

packages/node-core/src/integrations/local-variables/worker.ts

@@ -46,6 +46,7 @@ function unrollOther(prop: Runtime.PropertyDescriptor, vars: Variables): void {
   }
 
   if ('value' in prop.value) {
+    // oxlint-disable-next-line typescript/prefer-optional-chain
     if (prop.value.value === undefined || prop.value.value === null) {
       vars[prop.name] = `<${prop.value.value}>`;
     } else {

packages/node-core/src/utils/detection.ts

@@ -4,6 +4,7 @@ import { NODE_MAJOR, NODE_MINOR } from '../nodeVersion';
 /** Detect CommonJS. */
 export function isCjs(): boolean {
   try {
+    // oxlint-disable-next-line typescript/prefer-optional-chain
     return typeof module !== 'undefined' && typeof module.exports !== 'undefined';
   } catch {
     return false;

packages/react/src/hoist-non-react-statics.ts

@@ -146,7 +146,7 @@ export function hoistNonReactStatics<
       // Use key directly - String(key) throws for Symbols if minified to '' + key (#18966)
       if (
         !KNOWN_STATICS[key as keyof typeof KNOWN_STATICS] &&
-        !(excludelist && excludelist[key as keyof C]) &&
+        !excludelist?.[key as keyof C] &&
         !sourceStatics?.[key as string] &&
         !targetStatics?.[key as string] &&
         !getOwnPropertyDescriptor(targetComponent, key) // Don't overwrite existing properties

packages/react/src/reactrouter-compat-utils/instrumentation.tsx

@@ -614,8 +614,8 @@ export function createV6CompatibleWrapCreateMemoryRouter<
     const initialEntries = opts?.initialEntries;
     const initialIndex = opts?.initialIndex;
 
-    const hasOnlyOneInitialEntry = initialEntries && initialEntries.length === 1;
-    const hasIndexedEntry = initialIndex !== undefined && initialEntries && initialEntries[initialIndex];
+    const hasOnlyOneInitialEntry = initialEntries?.length === 1;
+    const hasIndexedEntry = initialIndex !== undefined && initialEntries?.[initialIndex];
 
     initialEntry = hasOnlyOneInitialEntry
       ? initialEntries[0]

packages/react/src/reactrouter-compat-utils/route-manifest.ts

@@ -36,7 +36,7 @@ const SORTED_MANIFEST_CACHE = new WeakMap<string[], string[]>();
  * Optionally strips a basename prefix before matching.
  */
 export function matchRouteManifest(pathname: string, manifest: string[], basename?: string): string | null {
-  if (!pathname || !manifest || !manifest.length) {
+  if (!pathname || !manifest?.length) {
     return null;
   }
 

packages/remix/src/client/performance.tsx

@@ -169,7 +169,7 @@ export function withSentry<P extends Record<string, unknown>, R extends React.Co
     const matches = _useMatches();
 
     _useEffect(() => {
-      const lastMatch = matches && matches[matches.length - 1];
+      const lastMatch = matches?.[matches.length - 1];
       if (lastMatch) {
         const { name, source } = getTransactionNameAndSource(location.pathname, lastMatch.id);
 

packages/replay-internal/src/coreHandlers/handleAfterSendEvent.ts

@@ -57,7 +57,7 @@ function handleErrorEvent(replay: ReplayContainer, event: ErrorEvent): void {
 
   // If error event is tagged with replay id it means it was sampled (when in buffer mode)
   // Need to be very careful that this does not cause an infinite loop
-  if (replay.recordingMode !== 'buffer' || !event.tags || !event.tags.replayId) {
+  if (replay.recordingMode !== 'buffer' || !event.tags?.replayId) {
     return;
   }
 

packages/replay-internal/src/replay.ts

@@ -748,8 +748,7 @@ export class ReplayContainer implements ReplayContainerInterface {
     if (
       this._lastActivity &&
       isExpired(this._lastActivity, this.timeouts.sessionIdlePause) &&
-      this.session &&
-      this.session.sampled === 'session'
+      this.session?.sampled === 'session'
     ) {
       // Pause recording only for session-based replays. Otherwise, resuming
       // will create a new replay and will conflict with users who only choose

packages/replay-internal/src/util/handleRecordingEmit.ts

@@ -146,7 +146,7 @@ export function createOptionsEvent(replay: ReplayContainer): ReplayOptionFrameEv
  */
 function addSettingsEvent(replay: ReplayContainer, isCheckout?: boolean): void {
   // Only need to add this event when sending the first segment
-  if (!isCheckout || !replay.session || replay.session.segmentId !== 0) {
+  if (!isCheckout || replay.session?.segmentId !== 0) {
     return;
   }
 

packages/sveltekit/src/server-common/handle.ts

@@ -254,6 +254,7 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
 
     // Escape hatch to suppress request isolation and trace continuation (see initCloudflareSentryHandle)
     const skipIsolation =
+      // oxlint-disable-next-line typescript/prefer-optional-chain
       '_sentrySkipRequestIsolation' in backwardsForwardsCompatibleEvent.locals &&
       backwardsForwardsCompatibleEvent.locals._sentrySkipRequestIsolation;