Skip to content

Make the Mirror Queue a queue #17326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 17, 2021
Merged

Make the Mirror Queue a queue #17326

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6154804
Make the Mirror Queue a queue
zeripath Oct 16, 2021
293c806
Remove MailService.QueueLength
zeripath Oct 16, 2021
0518c4b
Update modules/queue/unique_queue_channel.go
zeripath Oct 16, 2021
a30c432
as per delvh
zeripath Oct 16, 2021
07a304a
as per delvh
zeripath Oct 16, 2021
aee49c3
remove unnecessary line
zeripath Oct 16, 2021
6109ee0
Add clarification to queues configuration
zeripath Oct 16, 2021
54d8bff
Remove PullRequestQueueLength and MirrorQueueLength
zeripath Oct 16, 2021
128036d
use strconv too
zeripath Oct 16, 2021
3fb2d73
Merge branch 'main' into make-mirror-queue-a-queue
zeripath Oct 17, 2021
6d20582
oops
zeripath Oct 17, 2021
78b00fe
Merge branch 'main' into make-mirror-queue-a-queue
6543 Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update modules/queue/unique_queue_channel.go
  • Loading branch information
@zeripath
zeripath authored Oct 16, 2021
commit 0518c4bc66b9e801aa6101852e2fc814556d6a91
15 changes: 7 additions & 8 deletions modules/queue/unique_queue_channel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,13 @@ func NewChannelUniqueQueue(handle HandlerFunc, cfg, exemplar interface{}) (Queue
}
queue.WorkerPool = NewWorkerPool(func(data ...Data) {
for _, datum := range data {
bs, err := json.Marshal(datum)
if err != nil {
log.Error("unable to marshal data: %v", datum)
} else {
queue.lock.Lock()
delete(queue.table, string(bs))
queue.lock.Unlock()
}
// No error is possible here because PushFunc ensures that this can be marshalled
bs, _ := json.Marshal(datum)

queue.lock.Lock()
delete(queue.table, string(bs))
queue.lock.Unlock()

handle(datum)
}
}, config.WorkerPoolConfiguration)
Expand Down