Skip to content

Make the Mirror Queue a queue #17326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 17, 2021
Merged

Make the Mirror Queue a queue #17326

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6154804
Make the Mirror Queue a queue
zeripath Oct 16, 2021
293c806
Remove MailService.QueueLength
zeripath Oct 16, 2021
0518c4b
Update modules/queue/unique_queue_channel.go
zeripath Oct 16, 2021
a30c432
as per delvh
zeripath Oct 16, 2021
07a304a
as per delvh
zeripath Oct 16, 2021
aee49c3
remove unnecessary line
zeripath Oct 16, 2021
6109ee0
Add clarification to queues configuration
zeripath Oct 16, 2021
54d8bff
Remove PullRequestQueueLength and MirrorQueueLength
zeripath Oct 16, 2021
128036d
use strconv too
zeripath Oct 16, 2021
3fb2d73
Merge branch 'main' into make-mirror-queue-a-queue
zeripath Oct 17, 2021
6d20582
oops
zeripath Oct 17, 2021
78b00fe
Merge branch 'main' into make-mirror-queue-a-queue
6543 Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add clarification to queues configuration 
Signed-off-by: Andrew Thornton <[email protected]>
  • Loading branch information
@zeripath
zeripath committed Oct 16, 2021
commit 6109ee02ed6d5eb3ee6da2da7d20b387c4ff0d3f
17 changes: 16 additions & 1 deletion docs/content/doc/advanced/config-cheat-sheet.en-us.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ relation to port exhaustion.

## Queue (`queue` and `queue.*`)

Configuration at `[queue]` will set defaults for all queues with overrides for individual queues at `[queue.*]`.
Configuration at `[queue]` will set defaults for queues with overrides for individual queues at `[queue.*]`. (However see below.)

- `TYPE`: **persistable-channel**: General queue type, currently support: `persistable-channel` (uses a LevelDB internally), `channel`, `level`, `redis`, `dummy`
- `DATADIR`: **queues/**: Base DataDir for storing persistent and level queues. `DATADIR` for individual queues can be set in `queue.name` sections but will default to `DATADIR/`**`common`**. (Previously each queue would default to `DATADIR/`**`name`**.)
Expand Down Expand Up @@ -418,6 +418,21 @@ And the following unique queues:
- `mirror`
- `pr_patch_checker`

Certain queues have defaults that override the defaults set in `[queue]` (this occurs mostly to support older configuration):

- `[queue.issue_indexer]`
- `TYPE` this will default to `[queue]` `TYPE` if it is set but if not it will appropriately convert `[indexer]` `ISSUE_INDEXER_QUEUE_TYPE` if that is set.
- `LENGTH` will default to `[indexer]` `UPDATE_BUFFER_LEN` if that is set.
- `BATCH_LENGTH` will default to `[indexer]` `ISSUE_INDEXER_QUEUE_BATCH_NUMBER` if that is set.
- `DATADIR` will default to `[indexer]` `ISSUE_INDEXER_QUEUE_DIR` if that is set.
- `CONN_STR` will default to `[indexer]` `ISSUE_INDEXER_QUEUE_CONN_STR` if that is set.
- `[queue.mailer]`
- `LENGTH` will default to **100** or whatever `[mailer]` `SEND_BUFFER_LEN` is.
- `[queue.pr_patch_checker]`
- `LENGTH` will default to **1000** or whatever `[repository]` `PULL_REQUEST_QUEUE_LENGTH` is.
- `[queue.mirror]`
- `LENGTH` will default to **1000** or whatever `[repository]` `MIRROR_QUEUE_LENGTH` is.

## Admin (`admin`)

- `DEFAULT_EMAIL_NOTIFICATIONS`: **enabled**: Default configuration for email notifications for users (user configurable). Options: enabled, onmention, disabled
Expand Down