Skip to content

Make the Mirror Queue a queue #17326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 17, 2021
Merged

Make the Mirror Queue a queue #17326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6154804
Make the Mirror Queue a queue
zeripath Oct 16, 2021
293c806
Remove MailService.QueueLength
zeripath Oct 16, 2021
0518c4b
Update modules/queue/unique_queue_channel.go
zeripath Oct 16, 2021
a30c432
as per delvh
zeripath Oct 16, 2021
07a304a
as per delvh
zeripath Oct 16, 2021
aee49c3
remove unnecessary line
zeripath Oct 16, 2021
6109ee0
Add clarification to queues configuration
zeripath Oct 16, 2021
54d8bff
Remove PullRequestQueueLength and MirrorQueueLength
zeripath Oct 16, 2021
128036d
use strconv too
zeripath Oct 16, 2021
3fb2d73
Merge branch 'main' into make-mirror-queue-a-queue
zeripath Oct 17, 2021
6d20582
oops
zeripath Oct 17, 2021
78b00fe
Merge branch 'main' into make-mirror-queue-a-queue
6543 Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove PullRequestQueueLength and MirrorQueueLength 
Signed-off-by: Andrew Thornton <[email protected]>
  • Loading branch information
@zeripath
zeripath committed Oct 16, 2021
commit 54d8bff6269276f3b1c2d26f9cf8a836a742d4ab
4 changes: 2 additions & 2 deletions modules/setting/queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ func NewQueueService() {

// Handle the old test pull requests configuration
// Please note this will be a unique queue
handleOldLengthConfiguration("pr_patch_checker", Repository.PullRequestQueueLength)
handleOldLengthConfiguration("pr_patch_checker", Cfg.Section("repository").Key("PULL_REQUEST_QUEUE_LENGTH").MustInt(1000))

// Handle the old mirror queue configuration
// Please note this will be a unique queue
handleOldLengthConfiguration("mirror", Repository.MirrorQueueLength)
handleOldLengthConfiguration("mirror", Cfg.Section("repository").Key("MIRROR_QUEUE_LENGTH").MustInt(1000))
}

// handleOldLengthConfiguration allows fallback to older configuration. `[queue.name]` `LENGTH` will override this configuration, but
Expand Down
4 changes: 0 additions & 4 deletions modules/setting/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ var (
DefaultPrivate string
DefaultPushCreatePrivate bool
MaxCreationLimit int
MirrorQueueLength int
PullRequestQueueLength int
PreferredLicenses []string
DisableHTTPGit bool
AccessControlAllowOrigin string
Expand Down Expand Up @@ -142,8 +140,6 @@ var (
DefaultPrivate: RepoCreatingLastUserVisibility,
DefaultPushCreatePrivate: true,
MaxCreationLimit: -1,
MirrorQueueLength: 1000,
PullRequestQueueLength: 1000,
PreferredLicenses: []string{"Apache License 2.0", "MIT License"},
DisableHTTPGit: false,
AccessControlAllowOrigin: "",
Expand Down