Skip to content

Conversation

@ecrupper
Copy link
Contributor

Overlooked a potential casing mishap intended to be fixed in this PR: #700.

Previously only the repo casing was checked. This will verify both org and repo casing for creating repo secrets outside the UI.

@ecrupper ecrupper self-assigned this Sep 29, 2022
@ecrupper ecrupper requested a review from a team as a code owner September 29, 2022 19:36
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@23dfb84). Click here to learn what that means.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage        ?   54.97%           
=======================================
  Files           ?      211           
  Lines           ?    16021           
  Branches        ?        0           
=======================================
  Hits            ?     8808           
  Misses          ?     6836           
  Partials        ?      377           
Impacted Files Coverage Δ
api/secret.go 0.00% <0.00%> (ø)
scm/github/repo.go 74.55% <100.00%> (ø)

KellyMerrick
KellyMerrick previously approved these changes Sep 30, 2022
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants