update function name to make more sense

api/secret.go

@@ -141,7 +141,7 @@ func CreateSecret(c *gin.Context) {
 		// retrieve org and repo name from SCM
 		//
 		// same story as org secret. SCM has accurate casing.
-		scmOrg, scmRepo, err := scm.FromContext(c).GetRepoName(u, o, n)
+		scmOrg, scmRepo, err := scm.FromContext(c).GetOrgAndRepoName(u, o, n)
 		if err != nil {
 			retErr := fmt.Errorf("unable to retrieve repository %s/%s", o, n)
 

scm/github/repo.go

@@ -311,7 +311,7 @@ func (c *client) GetRepo(u *library.User, r *library.Repo) (*library.Repo, error
 }
 
 // GetRepoName returns the name of the repository in the SCM.
-func (c *client) GetRepoName(u *library.User, o string, r string) (string, string, error) {
+func (c *client) GetOrgAndRepoName(u *library.User, o string, r string) (string, string, error) {
 	c.Logger.WithFields(logrus.Fields{
 		"org":  o,
 		"repo": r,

scm/github/repo_test.go

@@ -1041,7 +1041,7 @@ func TestGithub_GetRepoName(t *testing.T) {
 	client, _ := NewTest(s.URL)
 
 	// run test
-	gotOrg, gotRepo, err := client.GetRepoName(u, "octocat", "Hello-World")
+	gotOrg, gotRepo, err := client.GetOrgAndRepoName(u, "octocat", "Hello-World")
 
 	if resp.Code != http.StatusOK {
 		t.Errorf("GetRepoName returned %v, want %v", resp.Code, http.StatusOK)
@@ -1084,7 +1084,7 @@ func TestGithub_GetRepoName_Fail(t *testing.T) {
 	client, _ := NewTest(s.URL)
 
 	// run test
-	_, _, err := client.GetRepoName(u, "octocat", "Hello-World")
+	_, _, err := client.GetOrgAndRepoName(u, "octocat", "Hello-World")
 
 	if err == nil {
 		t.Error("GetRepoName should return error")

scm/service.go

@@ -113,7 +113,7 @@ type Service interface {
 	GetRepo(*library.User, *library.Repo) (*library.Repo, error)
 	// GetRepoName defines a function that retrieves
 	// the name of the repo in the SCM.
-	GetRepoName(*library.User, string, string) (string, string, error)
+	GetOrgAndRepoName(*library.User, string, string) (string, string, error)
 	// GetOrg defines a function that retrieves
 	// the name for an org in the SCM.
 	GetOrgName(*library.User, string) (string, error)