Skip to content

fix(secret): check org casing for repo secret creation #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass3r merged 9 commits into from
Oct 3, 2022
Merged

fix(secret): check org casing for repo secret creation #708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
10166d2
fix(secret): check org casing for repo secret creation
ecrupper Sep 29, 2022
e4b68ae
update function name to make more sense
ecrupper Sep 29, 2022
c58e565
update comments and test names
ecrupper Sep 29, 2022
8bea137
update yet another comment
ecrupper Sep 29, 2022
0c4dd04
Merge branch 'main' into fix/include-org-casing-check
ecrupper Sep 29, 2022
07c2cbb
long sigh
ecrupper Sep 30, 2022
e51b929
Merge branch 'fix/include-org-casing-check' of github.com:go-vela/ser…
ecrupper Sep 30, 2022
8661400
Merge branch 'main' into fix/include-org-casing-check
ecrupper Sep 30, 2022
6d142e2
Merge branch 'main' into fix/include-org-casing-check
wass3r Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comments and test names
  • Loading branch information
@ecrupper
ecrupper committed Sep 29, 2022
commit c58e56541b9497cdfe496e48c2ac85f21521e41e
2 changes: 1 addition & 1 deletion scm/github/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ func (c *client) GetRepo(u *library.User, r *library.Repo) (*library.Repo, error
return toLibraryRepo(*repo), nil
}

// GetRepoName returns the name of the repository in the SCM.
// GetOrgAndRepoName returns the name of the org and the repository in the SCM.
func (c *client) GetOrgAndRepoName(u *library.User, o string, r string) (string, string, error) {
c.Logger.WithFields(logrus.Fields{
"org": o,
Expand Down
4 changes: 2 additions & 2 deletions scm/github/repo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ func TestGithub_GetRepo_Fail(t *testing.T) {
}
}

func TestGithub_GetRepoName(t *testing.T) {
func TestGithub_GetOrgAndRepoName(t *testing.T) {
// setup context
gin.SetMode(gin.TestMode)

Expand Down Expand Up @@ -1060,7 +1060,7 @@ func TestGithub_GetRepoName(t *testing.T) {
}
}

func TestGithub_GetRepoName_Fail(t *testing.T) {
func TestGithub_GetOrgAndRepoName_Fail(t *testing.T) {
// setup context
gin.SetMode(gin.TestMode)

Expand Down