Skip to content

Conversation

@plyr4
Copy link
Contributor

@plyr4 plyr4 commented Feb 27, 2023

NOTE this PR updates redis to v9 which requires the following changes:

see the CHANGELOG for more information

@plyr4 plyr4 requested a review from a team as a code owner February 27, 2023 15:36
@plyr4
Copy link
Contributor Author

plyr4 commented Feb 27, 2023

moving into draft to fix the mini-redis mock tests

@plyr4 plyr4 marked this pull request as draft February 27, 2023 15:40
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #771 (2773d36) into main (822be06) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   54.88%   54.87%   -0.01%     
==========================================
  Files         244      244              
  Lines       16490    16494       +4     
==========================================
+ Hits         9050     9051       +1     
- Misses       7041     7043       +2     
- Partials      399      400       +1     
Impacted Files Coverage Δ
queue/redis/pop.go 88.46% <ø> (-11.54%) ⬇️
queue/redis/push.go 85.00% <100.00%> (+3.75%) ⬆️
queue/redis/redis.go 85.98% <100.00%> (ø)

@plyr4 plyr4 marked this pull request as ready for review February 27, 2023 17:49
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants