-
Notifications
You must be signed in to change notification settings - Fork 30
chore(queue): update go-redis to v9 #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
moving into draft to fix the mini-redis mock tests |
Codecov Report
@@ Coverage Diff @@
## main #771 +/- ##
==========================================
- Coverage 54.88% 54.87% -0.01%
==========================================
Files 244 244
Lines 16490 16494 +4
==========================================
+ Hits 9050 9051 +1
- Misses 7041 7043 +2
- Partials 399 400 +1
|
ecrupper
approved these changes
Feb 27, 2023
wass3r
approved these changes
Feb 27, 2023
KellyMerrick
approved these changes
Feb 27, 2023
Contributor
KellyMerrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
timhuynh94
approved these changes
Feb 27, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE this PR updates redis to v9 which requires the following changes:
MaxConnAgechanged toConnMaxLifetimeIdleTimeoutchanged toConnMaxIdleTimeIdleCheckFrequencywas replaced in favor ofMaxIdleConnsRPushno longer supports addingnilitems, so a check has been added to thePushwrapper. tests have been updated to reflect the change. see: Allow struct on HSet redis/go-redis#1960 and https://github.com/redis/go-redis/releases/tag/v9.0.2see the CHANGELOG for more information