Skip to content

chore(queue): update go-redis to v9 #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plyr4 merged 7 commits into from
Feb 27, 2023
Merged

chore(queue): update go-redis to v9 #771

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a9a5b66
fix(deps): update module github.com/go-redis/redis/v8 to v9
renovate[bot] Feb 27, 2023
4bed99f
fix: redis v9 struct changes
plyr4 Feb 27, 2023
9b12eb8
fix: add MaxIdleConns
plyr4 Feb 27, 2023
5f028c9
temp: remove test temporarily
plyr4 Feb 27, 2023
382d555
fix: move nil test from pop to push
plyr4 Feb 27, 2023
a78c633
fix: add bytes in badChannel test
plyr4 Feb 27, 2023
2773d36
chore: comments on the nil check in Push
plyr4 Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: move nil test from pop to push
  • Loading branch information
@plyr4
plyr4 committed Feb 27, 2023
commit 382d555864ebbaeeec199ff67429b8a2498ad741
23 changes: 0 additions & 23 deletions queue/redis/pop_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,24 +58,6 @@ func TestRedis_Pop(t *testing.T) {
// overwrite channel to be invalid
badChannel.config.Channels = nil

// push nothing to queue
// err = badChannel.Redis.RPush(context.Background(), "vela", nil).Err()
// if err != nil {
// t.Errorf("unable to push item to queue: %v", err)
// }

// setup badItem redis mock
// badItem, err := NewTest("vela")
// if err != nil {
// t.Errorf("unable to create queue service: %v", err)
// }

// push nothing to queue
// err = badItem.Redis.RPush(context.Background(), "vela", nil).Err()
// if err != nil {
// t.Errorf("unable to push item to queue: %v", err)
// }

// setup tests
tests := []struct {
failure bool
Expand All @@ -97,11 +79,6 @@ func TestRedis_Pop(t *testing.T) {
redis: badChannel,
want: nil,
},
// {
// failure: true,
// redis: badItem,
// want: nil,
// },
}

// run tests
Expand Down
17 changes: 15 additions & 2 deletions queue/redis/push_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func TestRedis_Push(t *testing.T) {
}

// setup queue item
bytes, err := json.Marshal(_item)
_bytes, err := json.Marshal(_item)
if err != nil {
t.Errorf("unable to marshal queue item: %v", err)
}
Expand All @@ -34,20 +34,33 @@ func TestRedis_Push(t *testing.T) {
t.Errorf("unable to create queue service: %v", err)
}

// setup redis mock
badItem, err := NewTest("vela")
if err != nil {
t.Errorf("unable to create queue service: %v", err)
}

// setup tests
tests := []struct {
failure bool
redis *client
bytes []byte
}{
{
failure: false,
redis: _redis,
bytes: _bytes,
},
{
failure: true,
redis: badItem,
bytes: nil,
},
}

// run tests
for _, test := range tests {
err := _redis.Push(context.Background(), "vela", bytes)
err := test.redis.Push(context.Background(), "vela", test.bytes)

if test.failure {
if err == nil {
Expand Down