Skip to content

chore(queue): update go-redis to v9 #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plyr4 merged 7 commits into from
Feb 27, 2023
Merged

chore(queue): update go-redis to v9 #771

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a9a5b66
fix(deps): update module github.com/go-redis/redis/v8 to v9
renovate[bot] Feb 27, 2023
4bed99f
fix: redis v9 struct changes
plyr4 Feb 27, 2023
9b12eb8
fix: add MaxIdleConns
plyr4 Feb 27, 2023
5f028c9
temp: remove test temporarily
plyr4 Feb 27, 2023
382d555
fix: move nil test from pop to push
plyr4 Feb 27, 2023
a78c633
fix: add bytes in badChannel test
plyr4 Feb 27, 2023
2773d36
chore: comments on the nil check in Push
plyr4 Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: comments on the nil check in Push
  • Loading branch information
@plyr4
plyr4 committed Feb 27, 2023
commit 2773d36f9db19c00054fb2ff3c8e219e7f4ca8a3
4 changes: 4 additions & 0 deletions queue/redis/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ import (
func (c *client) Push(ctx context.Context, channel string, item []byte) error {
c.Logger.Tracef("pushing item to queue %s", channel)

// ensure the item to be pushed is valid
// go-redis RPush does not support nil as of v9.0.2
//
// https://github.com/redis/go-redis/pull/1960
if item == nil {
return errors.New("item is nil")
}
Expand Down