Skip to content

Fix naming conventions and optional/required fields in company credit GraphQL schema #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melnikovi merged 3 commits into from
Oct 22, 2020
Merged

Fix naming conventions and optional/required fields in company credit GraphQL schema #446

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0ed464
Add missing uids to the types and validate optional/required fields
melnikovi Oct 1, 2020
3620b9b
Add missing uids to the types and validate optional/required fields
melnikovi Oct 1, 2020
c9ce7e9
Clarify what is CompanyCreditOperation.uid
melnikovi Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions design-documents/graph-ql/coverage/b2b/company-credit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,15 @@ type Company {
###### Begin: Defining new types ######
type CompanyCreditHistory {
items: [CompanyCreditOperation]! @doc(description: "An array of company credit operations")
page_info: SearchResultPageInfo! @doc(description: "Metadata for pagination rendering")
total_count: Int @doc(description: "The number of the company credit operations matching the specified filter")
page_info: SearchResultPageInfo @doc(description: "Metadata for pagination rendering")
total_count: Int! @doc(description: "The number of the company credit operations matching the specified filter")
}

type CompanyCreditOperation {
uid: ID! @doc(description: "Unique identifier")
Copy link

@prabhuram93 prabhuram93 Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melnikovi can you add, what this identifier should be composed of.

date: String! @doc(description: "The date of the company credit operation")
type: CompanyCreditOperationType! @doc(description: "The type of the company credit operation")
amount: Money @doc(description: "The amount fo the company credit operation")
amount: Money! @doc(description: "The amount fo the company credit operation")
balance: CompanyCredit! @doc(description: "Credit balance after the company credit operation")
custom_reference_number: String @doc(description: "Custom reference number associated with the company credit operation")
updated_by: CompanyCreditOperationUser! @doc(description: "The user submitting the company credit operation")
Expand Down