Make DateTime#valueOf call #toMillis #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icambron
reviewed
Jun 17, 2018
|
|
||
| test('Invalid DateTimes return invalid Dates', () => { | ||
| expect(organic1.toJSDate().valueOf()).toBeFalsy(); | ||
| expect(organic1.toJSDate().valueOf()).toBe(NaN); |
Contributor
There was a problem hiding this comment.
Surprised this works, actually.
Contributor
Author
There was a problem hiding this comment.
It didn't work initially, was fixed by jestjs/jest#4917, that's why I updated jest.
Contributor
|
This looks good. The build error is probably because I haven't pinned down the version of prettier. I bet if you |
Contributor
Author
|
BTW, that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior:
toMilliscallsvalueOf.This PR aligns Luxon's
DateTime#valueOfwith it's very ownDuration#valueOf(introduced in #261), implementation in moment.js, and the nativeDate#valueOf. They all have logiclessvalueOfthat just calls some other method. And no other method callsvalueOfdirectly, only JavaScript does.