Skip to content

Make DateTime#valueOf call #toMillis #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icambron merged 9 commits into from
Jun 18, 2018
Merged

Make DateTime#valueOf call #toMillis #275

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bca121d
Make `NaN` comparison more precise
shvaikalesh Jun 17, 2018
1eed2d6
Tweak `DateTime#equals`
shvaikalesh Jun 17, 2018
052b090
Use `Date.now()`
shvaikalesh Jun 17, 2018
a54a96e
Swap `#valueOf` and `#toMillis`
shvaikalesh Jun 17, 2018
cec0ab9
Improve `#toMillis` coverage
shvaikalesh Jun 17, 2018
f75c0c8
Use single quotes
shvaikalesh Jun 17, 2018
abdb02d
Update `jest`
shvaikalesh Jun 17, 2018
b379d13
Merge remote-tracking branch 'moment/master' into value-of
shvaikalesh Jun 17, 2018
178d127
Reformat
shvaikalesh Jun 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make NaN comparison more precise
  • Loading branch information
@shvaikalesh
shvaikalesh committed Jun 17, 2018
commit bca121d38cfe5bc0de5c11198dcccdf2787040fe
2 changes: 1 addition & 1 deletion test/datetime/invalid.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ test('Invalid tell you why', () => {
});

test('Invalid DateTimes return invalid Dates', () => {
expect(organic1.toJSDate().valueOf()).toBeFalsy();
expect(organic1.toJSDate().valueOf()).toBe(NaN);
Copy link
Contributor

@icambron icambron Jun 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised this works, actually.

Copy link
Contributor Author

@shvaikalesh shvaikalesh Jun 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work initially, was fixed by jestjs/jest#4917, that's why I updated jest.

});

test('Diffing invalid DateTimes creates invalid Durations', () => {
Expand Down