Skip to content

Make DateTime#valueOf call #toMillis #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icambron merged 9 commits into from
Jun 18, 2018
Merged

Make DateTime#valueOf call #toMillis #275

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bca121d
Make `NaN` comparison more precise
shvaikalesh Jun 17, 2018
1eed2d6
Tweak `DateTime#equals`
shvaikalesh Jun 17, 2018
052b090
Use `Date.now()`
shvaikalesh Jun 17, 2018
a54a96e
Swap `#valueOf` and `#toMillis`
shvaikalesh Jun 17, 2018
cec0ab9
Improve `#toMillis` coverage
shvaikalesh Jun 17, 2018
f75c0c8
Use single quotes
shvaikalesh Jun 17, 2018
abdb02d
Update `jest`
shvaikalesh Jun 17, 2018
b379d13
Merge remote-tracking branch 'moment/master' into value-of
shvaikalesh Jun 17, 2018
178d127
Reformat
shvaikalesh Jun 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use single quotes
  • Loading branch information
@shvaikalesh
shvaikalesh committed Jun 17, 2018
commit f75c0c8cb0366fd53a51044a3b8b9a9af8036109
10 changes: 5 additions & 5 deletions test/datetime/transform.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,22 @@ const dtMaker = () =>
//------
// #toMillis()
//------
test("DateTime#toMillis() returns milliseconds for valid DateTimes", () => {
test('DateTime#toMillis() returns milliseconds for valid DateTimes', () => {
const js = dt.toJSDate();
expect(dt.toMillis()).toBe(js.getTime());
});

test("DateTime#toMillis() returns NaN for invalid DateTimes", () => {
const invalid = DateTime.invalid("reason");
test('DateTime#toMillis() returns NaN for invalid DateTimes', () => {
const invalid = DateTime.invalid('reason');
expect(invalid.toMillis()).toBe(NaN);
});

//------
// #valueOf()
//------
test("DateTime#valueOf() just does toMillis()", () => {
test('DateTime#valueOf() just does toMillis()', () => {
expect(dt.valueOf()).toBe(dt.toMillis());
const invalid = DateTime.invalid("reason");
const invalid = DateTime.invalid('reason');
expect(invalid.valueOf()).toBe(invalid.toMillis());
});

Expand Down