Skip to content

fix overlapping menu #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szaimen wants to merge 1 commit into from
Closed

fix overlapping menu #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion styles/toast.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
padding-right: 34px;
margin-top: 45px;
position: fixed;
z-index: 10100;
z-index: 2000; // Needs to be below Nextcloud menu entries see https://github.com/nextcloud/server/issues/26518
Copy link
Contributor

@juliusknorr juliusknorr Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a regression with modals as the 10100 value was introduced in #236 to fix that

Copy link
Contributor Author

@szaimen szaimen Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for which modals would this apply?

Copy link
Contributor

@juliusknorr juliusknorr Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any modal from the vue library for example: viewer, firstrunwizard, settings dialogs

Copy link
Contributor Author

@szaimen szaimen Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in this case do you see a way to fix this nextcloud/server#26518 at all?

Copy link
Contributor Author

@szaimen szaimen Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe can we move the toasts a bit to the left? so that it doesn't overlap anymore with the menu?

Copy link
Contributor

@juliusknorr juliusknorr Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in this case do you see a way to fix this nextcloud/server#26518 at all?

Can't think of a proper way currently. The issue is that the modal should overlap all content (also the header menus) while the toast should still be overlapped by the menus.

maybe can we move the toasts a bit to the left? so that it doesn't overlap anymore with the menu?

Also not a solution as the menu has a dynamic width depending on the translations and the same issue also exists for the other popovers like search.

Copy link
Contributor Author

@szaimen szaimen Sep 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl Is there maybe a way to have the z-index for the dialogs by default on 2000 and simply increase it to 10100 when the modal opens and reset it again when it gets closed?

Copy link
Contributor

@nickvergessen nickvergessen Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there maybe a way to have the z-index for the dialogs by default on 2000 and simply increase it to 10100 when the modal opens and reset it again when it gets closed?

Not sure how that would solve anything. Notifications e.g. is a popup just like in the screenshot, but the toasts triggered from it should overlap the popup. So the library can not solve this. In the case above we should:

  1. Make sure the quota error is only shown once
  2. The user should use the close button to navigate to the menu.

border-radius: var(--border-radius);

.toast-undo-button,
Expand Down