Skip to content

Conversation

@nickvergessen
Copy link
Member

Regression from #14626

  • Try to load any /f/{fileid} link

@nickvergessen
Copy link
Member Author

Same wrong hack (route name method not matching the invoked method) was used in talk:
nextcloud/spreed#1612

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

* @param string $fileid
* @return TemplateResponse|RedirectResponse
*/
public function showFile(string $fileid = null): Response {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto 2019-03-14 um 16 27 07

🙈 Let me fix that.

Signed-off-by: Morris Jobke <[email protected]>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 14, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17013: failure

TESTS=acceptance, TESTS-ACCEPTANCE=apps

  • tests/acceptance/features/apps.feature:83
Show full log
  Scenario: Install an app from the app store                     # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:83
    Given I act as Jane                                           # ActorContext::iActAs()
    And I am logged in as the admin                               # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                                # SettingsMenuContext::iOpenTheAppsManagement()
    And I open the "Tools" section                                # AppNavigationContext::iOpenTheSection()
      Tools section item in App Navigation could not be found after 100 seconds (NoSuchElementException)
    And I click on the "Antivirus for files" app                  # AppsManagementContext::iClickOnTheApp()
    And I see that the app details are shown                      # AppsManagementContext::iSeeThatTheAppDetailsAreShown()
    Then I download and enable the "Antivirus for files" app      # AppsManagementContext::iDownloadAndEnableTheApp()
    And I see that the "Antivirus for files" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
Copy link
Member

  • tests/acceptance/features/apps.feature:83

"fixed" in #14681

@MorrisJobke MorrisJobke merged commit 5d2edc4 into master Mar 14, 2019
@MorrisJobke MorrisJobke deleted the bugfix/noid/fix-hardcoded-f-url-handling branch March 14, 2019 22:30
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants