Skip to content

Conversation

@juliusknorr
Copy link
Member

  • Open the security settings on mobile
  • scroll down to the token list
  • Tap the 3-dots menu

Before:
See no menu (since it has boundaries to the body element which is out of the visible area)

After:
See the menu

See nextcloud-libraries/nextcloud-vue#1384 for the background of this issue, though I cannot see any easy solution for this now to fix this in the vue lib.

@juliusknorr
Copy link
Member Author

/compile amend /

@juliusknorr
Copy link
Member Author

/backport to stable20

@raimund-schluessler
Copy link
Member

@juliushaertl If you already start to fix this on a per-app basis, how about doing it with CSS instead like so (see #22606 (comment))

body { /* Maybe add "#body-settings" */
	min-height: 100%;
	height: auto; /* necessary to overwrite the server css rule */
}

by adding this to the settings app CSS. It would need a bit of testing, that it doesn't break anything on the settings app, but it should also fix the issue with the app token menu and it would additionally also fix the status selection popover which has the same issue when scrolled down.

@juliusknorr
Copy link
Member Author

Ah indeed that would make more sense then, since the bdoy is the scroll container anyways there is no reason to limit it to 100% height (for the apps that don't have a custom scroll container)

@juliusknorr
Copy link
Member Author

Closing then and I'll prepare an individual fix for the whole settings app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants