Skip to content

Conversation

@ChristophWurst
Copy link
Member

This is a revival of #6508

  • I don't know where this add function is called, so I can't change that to be able to work with async operations
  • The error handling is most likely not sufficient
  • Not sure if the propfind is always necessary or correct. It works for external storage, tho.

@nextcloud/javascript I know this is some of our ugliest code but any help is HIGHLY appreciate 🙏

Fixes #5437

Signed-off-by: Christoph Wurst <[email protected]>
@kesselb
Copy link
Contributor

kesselb commented Oct 8, 2020

Looks like fun 😆

@ChristophWurst
Copy link
Member Author

Looks like fun laughing

Thanks for the supportive comment 😉

@nextcloud nextcloud deleted a comment from faily-bot bot Oct 9, 2020
@juliusknorr
Copy link
Member

I just had a quick look, but I'll check it more in detail next week.

I don't know where this add function is called, so I can't change that to be able to work with async operations

It is called by the jquery.fileupload plugin, I'd probably stay away from patching around in that 🙈

Not sure if the propfind is always necessary or correct. It works for external storage, tho.

We could probably just extend the existing profind with the d:quota-available-bytes property so we have the infomation around already in the filelist, but that might have a performance impact, not sure about that right now.

@juliusknorr
Copy link
Member

I've pushed my idea of the implementation to #24102

@ChristophWurst
Copy link
Member Author

#24102 works very nicely and is less hacky.

@ChristophWurst ChristophWurst deleted the fix/upload-shared-folder-quota branch November 17, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dragging a file on a shared folder checks your quota while dragging a file inside an *opened* shared folder checks quota of folder owner

4 participants