Fix incorrect quota in upload to shared folder by PROPFIND #6508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP. This fixes issue #5437. It replaces reading the folder's free space from
the #free_space HTML element by a WebDAV PROPFIND request. This is
relevant if uploading by dragging onto a shared folder's icon in the web
interface, as #free_space reports the user's quota whereas PROPFIND
returns the quota of the share's owner in that case.
I am new to this code base and need feedback on the following remaining issues:
upload._targetFolder, which looks like a private function name. Is there a better way to get the upload target name?$("#free_space")could still be used. How do I determine in JavaScript if the target folder is a shared folder?