Skip to content

Conversation

@mlell
Copy link

@mlell mlell commented Sep 14, 2017

This is still WIP. This fixes issue #5437. It replaces reading the folder's free space from
the #free_space HTML element by a WebDAV PROPFIND request. This is
relevant if uploading by dragging onto a shared folder's icon in the web
interface, as #free_space reports the user's quota whereas PROPFIND
returns the quota of the share's owner in that case.

I am new to this code base and need feedback on the following remaining issues:

  • I determine the upload target folder name by upload._targetFolder, which looks like a private function name. Is there a better way to get the upload target name?
  • I do the PROPFIND by OC.Files.getClient()._client.propFind(...), which looks hacky to me. Is this the public API?
  • It would save network bandwith if the PROPFIND would only be performed in the case that a file was dragged to the icon of a shared folder. Otherwise the content of $("#free_space") could still be used. How do I determine in JavaScript if the target folder is a shared folder?

This fixes issue nextcloud#5437. It replaces reading the folder's free space from
the #free_space HTML element by a WebDAV PROPFIND request. This is
relevant if uploading by dragging onto a shared folder's icon in the web
interface, as #free_space reports the user's quota whereas PROPFIND
returns the quota of the share's owner in that case.
@rullzer
Copy link
Member

rullzer commented Sep 15, 2017

Thnx for starting this @mlell!
@danxuliu if you want to have more js fun ;)

@MorrisJobke
Copy link
Member

Could somebody from @nextcloud/javascript have a look at this?

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 7, 2018
@rullzer rullzer added the bug label May 23, 2018
@MorrisJobke MorrisJobke added the stale Ticket or PR with no recent activity label Jun 19, 2018
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 9, 2018
@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jul 9, 2018
@MorrisJobke
Copy link
Member

@danxuliu @skjnldsv @juliushaertl Hasn't one of you recently looked into this?

@skjnldsv
Copy link
Member

Not me :)

@rullzer
Copy link
Member

rullzer commented Sep 15, 2019

I'm going to close this.
If anybody wants to pick this up feel free to reopen and rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants