Skip to content

[stable20] Add missing waits and asserts in acceptance tests #25994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 9 commits into from
Mar 9, 2021
Merged

[stable20] Add missing waits and asserts in acceptance tests #25994

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8077dbf
Add missing waits when finding elements in the acceptance tests
danxuliu Jan 17, 2021
dd1a554
Verify WaitFor::element... results with an assertion
danxuliu Mar 5, 2021
d548d21
Fix delete user acceptance test
danxuliu Mar 6, 2021
5859458
Fix identation
danxuliu Mar 5, 2021
d293751
Add locator for apps list
danxuliu Mar 5, 2021
00b38db
Find elements through the actor rather than the driver
danxuliu Mar 5, 2021
30c91a7
Add explicit locator for "Enable all" bundle button
danxuliu Mar 5, 2021
f92a216
Assert also element visibility instead of just finding it
danxuliu Mar 5, 2021
ace7b9d
Find directly the label instead of falling back to it
danxuliu Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add locator for apps list 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @backportbot
danxuliu authored and backportbot[bot] committed Mar 8, 2021
commit d293751ba7b1d1592f51e54cd584f82012a04a04
20 changes: 16 additions & 4 deletions tests/acceptance/features/bootstrap/AppsManagementContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@
class AppsManagementContext implements Context, ActorAwareInterface {
use ActorAware;

/**
* @return Locator
*/
public static function appsList() {
return Locator::forThe()->xpath("//main[@id='app-content' or contains(@class, 'app-content')]//div[@id='apps-list']")->
describedAs("Apps list in Apps Management");
}

/**
* @return Locator
*/
Expand Down Expand Up @@ -59,31 +67,35 @@ public static function disableButtonForApp($app) {
* @return Locator
*/
public static function bundleButton($bundle) {
return Locator::forThe()->xpath("//main[@id='app-content' or contains(@class, 'app-content')]//div[@class='apps-header']/h2[normalize-space() = '$bundle']/input")->
return Locator::forThe()->xpath("//div[@class='apps-header']/h2[normalize-space() = '$bundle']/input")->
descendantOf(self::appsList())->
describedAs("Button to enable / disable bundles");
}

/**
* @return Locator
*/
public static function rowForApp($app) {
return Locator::forThe()->xpath("//main[@id='app-content' or contains(@class, 'app-content')]//div[@class='app-name'][normalize-space() = '$app']/..")->
return Locator::forThe()->xpath("//div[@class='app-name'][normalize-space() = '$app']/..")->
descendantOf(self::appsList())->
describedAs("Row for app $app in Apps Management");
}

/**
* @return Locator
*/
public static function emptyAppList() {
return Locator::forThe()->xpath("//main[@id='app-content' or contains(@class, 'app-content')]//div[@id='apps-list-empty']")->
return Locator::forThe()->xpath("//div[@id='apps-list-empty']")->
descendantOf(self::appsList())->
describedAs("Empty apps list view");
}

/**
* @return Locator
*/
public static function appEntries() {
return Locator::forThe()->xpath("//main[@id='app-content' or contains(@class, 'app-content')]//div[@class='section']")->
return Locator::forThe()->xpath("//div[@class='section']")->
descendantOf(self::appsList())->
describedAs("Entries in apps list");
}

Expand Down