Skip to content

[stable20] Add missing waits and asserts in acceptance tests #25994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 9 commits into from
Mar 9, 2021
Merged

[stable20] Add missing waits and asserts in acceptance tests #25994

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8077dbf
Add missing waits when finding elements in the acceptance tests
danxuliu Jan 17, 2021
dd1a554
Verify WaitFor::element... results with an assertion
danxuliu Mar 5, 2021
d548d21
Fix delete user acceptance test
danxuliu Mar 6, 2021
5859458
Fix identation
danxuliu Mar 5, 2021
d293751
Add locator for apps list
danxuliu Mar 5, 2021
00b38db
Find elements through the actor rather than the driver
danxuliu Mar 5, 2021
30c91a7
Add explicit locator for "Enable all" bundle button
danxuliu Mar 5, 2021
f92a216
Assert also element visibility instead of just finding it
danxuliu Mar 5, 2021
ace7b9d
Find directly the label instead of falling back to it
danxuliu Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix delete user acceptance test 
Adding some missing asserts showed that the "delete user" acceptance
test was silently failing, as the deletion was not being confirmed in
the dialog and thus the user was not being deleted.

The dialog button contains a single quote ("user0's"), so the XPath
expression had to be adjusted (it seems that it is not possible to
escape a single quote in a string enclosed in single quotes in XPath
1.0).

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @backportbot
danxuliu authored and backportbot[bot] committed Mar 8, 2021
commit d548d212a25b6c77eebcd3a2bac0631b7a788281
2 changes: 1 addition & 1 deletion tests/acceptance/features/bootstrap/DialogContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public static function theDialog() {
* @return Locator
*/
public static function theDialogButton($text) {
return Locator::forThe()->xpath("//button[normalize-space() = '$text']")->
return Locator::forThe()->xpath("//button[normalize-space() = \"$text\"]")->
descendantOf(self::theDialog())->
describedAs($text . " button of the dialog");
}
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/users.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Feature: users
And I open the actions menu for the user user0
And I see that the "Delete user" action in the user0 actions menu is shown
When I click the "Delete user" action in the user0 actions menu
And I click the "Delete user0's account" button of the confirmation dialog
Then I see that the list of users does not contains the user user0

Scenario: disable a user
Expand Down