Skip to content

[stable20] Add missing waits and asserts in acceptance tests #25994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 9 commits into from
Mar 9, 2021
Merged

[stable20] Add missing waits and asserts in acceptance tests #25994

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8077dbf
Add missing waits when finding elements in the acceptance tests
danxuliu Jan 17, 2021
dd1a554
Verify WaitFor::element... results with an assertion
danxuliu Mar 5, 2021
d548d21
Fix delete user acceptance test
danxuliu Mar 6, 2021
5859458
Fix identation
danxuliu Mar 5, 2021
d293751
Add locator for apps list
danxuliu Mar 5, 2021
00b38db
Find elements through the actor rather than the driver
danxuliu Mar 5, 2021
30c91a7
Add explicit locator for "Enable all" bundle button
danxuliu Mar 5, 2021
f92a216
Assert also element visibility instead of just finding it
danxuliu Mar 5, 2021
ace7b9d
Find directly the label instead of falling back to it
danxuliu Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Assert also element visibility instead of just finding it 
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu @backportbot
danxuliu authored and backportbot[bot] committed Mar 8, 2021
commit f92a216dcf80a2e5cfbe2a956dfbc1abd0a1add6
16 changes: 12 additions & 4 deletions tests/acceptance/features/bootstrap/AppsManagementContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,19 @@ public function iDisableTheApp($app) {
*/
public function iSeeThatTheAppHasBeenEnabled($app) {
// TODO: Find a way to check if the enable button is removed
$this->actor->find(self::disableButtonForApp($app), 10);
PHPUnit_Framework_Assert::assertTrue(
$this->actor->find(self::disableButtonForApp($app), 10)->isVisible()
);
}

/**
* @Then I see that the :app app has been disabled
*/
public function iSeeThatTheAppHasBeenDisabled($app) {
// TODO: Find a way to check if the disable button is removed
$this->actor->find(self::enableButtonForApp($app), 10);
PHPUnit_Framework_Assert::assertTrue(
$this->actor->find(self::enableButtonForApp($app), 10)->isVisible()
);
}

/**
Expand Down Expand Up @@ -237,8 +241,12 @@ public function iSeeThatThereAreOnlyEnabledApps() {
* @Given /^I see the app bundles$/
*/
public function iSeeTheAppBundles() {
$this->actor->find(self::rowForApp('Auditing / Logging'), 2);
$this->actor->find(self::rowForApp('LDAP user and group backend'), 2);
PHPUnit_Framework_Assert::assertTrue(
$this->actor->find(self::rowForApp('Auditing / Logging'), 2)->isVisible()
);
PHPUnit_Framework_Assert::assertTrue(
$this->actor->find(self::rowForApp('LDAP user and group backend'), 2)->isVisible()
);
}

/**
Expand Down