fix(dialogs): migrate buttons to variant prop #55848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Nextcloud Vue v8 the `type` prop for dialog buttons was deprecated and replaces with the `variant` prop. In v9 the deprecated props are removed. Use the `variant` prop in the deprecated `OC.dialogs`. This is a follow up for #55726. Signed-off-by: Max <[email protected]>
max-nextcloud
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
susnux
approved these changes
Oct 19, 2025
mejo-
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nextcloud Vue v8 the
typeprop for dialog buttonswas deprecated and replaces with the
variantprop.In v9 the deprecated props are removed.
Use the
variantprop in the deprecatedOC.dialogs.This is a follow up for #55726.