-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable32] chore: Update @nextcloud/dialogs to v7.0.0
#57129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24b1211 to
81bc59f
Compare
susnux
approved these changes
Dec 16, 2025
artonge
approved these changes
Dec 17, 2025
This is the first step torwards Vue 3. As this package is a Vue version agnostic version of dialogs, written in Vue 3. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
In Nextcloud Vue v8 the `type` prop for dialog buttons was deprecated and replaces with the `variant` prop. In v9 the deprecated props are removed. Use the `variant` prop in the deprecated `OC.dialogs`. This is a follow up for #55726. Signed-off-by: Max <[email protected]>
`.only` is only to be used for development, but must not be committed. Instead failing tests which should be kept for later should be skipped (`.skip`). Signed-off-by: Ferdinand Thiessen <[email protected]>
81bc59f to
d9b0346
Compare
Contributor
|
/compile |
artonge
approved these changes
Dec 17, 2025
fb32d5d to
47bed13
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
47bed13 to
0cd1ef6
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
0cd1ef6 to
9e4b966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nextcloud/dialogsto v7.0.0 #55726This backport allows to reduce maintenance work when doing backports from 33 to 32 but most important it reduces libraries to maintain as now we only need to maintain v6 until 31 is EOL.
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.