Skip to content

[stable32] chore: Update @nextcloud/dialogs to v7.0.0 #57129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 9 commits into from
Dec 17, 2025
Merged

[stable32] chore: Update @nextcloud/dialogs to v7.0.0 #57129

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2662901
chore: Update `@nextcloud/dialogs` to v7.0.0
susnux Oct 13, 2025
a387134
refactor: adjust code for breaking changes in `@nextcloud/dialogs` v7
susnux Oct 13, 2025
689cbdf
test: adjust FilePicker tests to new dialogs version
susnux Oct 15, 2025
463a5bd
fix(dialogs): migrate buttons to variant prop
max-nextcloud Oct 18, 2025
d9b0346
chore: ensure no `.only` is commited in test files
susnux Oct 15, 2025
b770bbd
refactor(test): migrate cypress component tests to vitest
susnux Oct 14, 2025
1f72fd3
refactor(test): migrate component tests in core to vitest
susnux Oct 14, 2025
eb2475e
chore: remove Cypress component testing
susnux Oct 14, 2025
9e4b966
chore: compile assets
susnux Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(dialogs): migrate buttons to variant prop 
In Nextcloud Vue v8 the `type` prop for dialog buttons
was deprecated and replaces with the `variant` prop.

In v9 the deprecated props are removed.
Use the `variant` prop in the deprecated `OC.dialogs`.

This is a follow up for #55726.

Signed-off-by: Max <[email protected]>
  • Loading branch information
@max-nextcloud @susnux
max-nextcloud authored and susnux committed Dec 17, 2025
commit 463a5bd0334c1faf4549dd3300fecb85d382aeb8
16 changes: 8 additions & 8 deletions core/src/OC/dialogs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ const Dialogs = {
? [
{
label: t('core', 'Yes'),
type: 'error',
variant: 'error',
callback: () => {
callback.clicked = true
callback(true)
Expand Down Expand Up @@ -148,7 +148,7 @@ const Dialogs = {
},
{
label: t('core', 'Yes'),
type: 'primary',
variant: 'primary',
callback: () => {
callback.clicked = true
callback(true)
Expand Down Expand Up @@ -271,7 +271,7 @@ const Dialogs = {
builder.addButton({
callback: legacyCallback(callback, button.type),
label: button.text,
type: button.defaultButton ? 'primary' : 'secondary',
variant: button.defaultButton ? 'primary' : 'secondary',
})
})
} else {
Expand All @@ -284,22 +284,22 @@ const Dialogs = {
buttons.push({
callback: legacyCallback(callback, FilePickerType.Choose),
label: node && !this.multiSelect ? t('core', 'Choose {file}', { file: target }) : t('core', 'Choose'),
type: 'primary',
variant: 'primary',
})
}
if (type === FilePickerType.CopyMove || type === FilePickerType.Copy) {
buttons.push({
callback: legacyCallback(callback, FilePickerType.Copy),
label: target ? t('core', 'Copy to {target}', { target }) : t('core', 'Copy'),
type: 'primary',
variant: 'primary',
icon: IconCopy,
})
}
if (type === FilePickerType.Move || type === FilePickerType.CopyMove) {
buttons.push({
callback: legacyCallback(callback, FilePickerType.Move),
label: target ? t('core', 'Move to {target}', { target }) : t('core', 'Move'),
type: type === FilePickerType.Move ? 'primary' : 'secondary',
variant: type === FilePickerType.Move ? 'primary' : 'secondary',
icon: IconMove,
})
}
Expand Down Expand Up @@ -374,7 +374,7 @@ const Dialogs = {
})
buttonList.push({
label: buttons?.confirm ?? t('core', 'Yes'),
type: 'primary',
variant: 'primary',
callback: () => {
callback._clicked = true
callback(true)
Expand All @@ -384,7 +384,7 @@ const Dialogs = {
case Dialogs.OK_BUTTONS:
buttonList.push({
label: buttons?.confirm ?? t('core', 'OK'),
type: 'primary',
variant: 'primary',
callback: () => {
callback._clicked = true
callback(true)
Expand Down