Skip to content

Conversation

@Faldon
Copy link
Contributor

@Faldon Faldon commented Jul 29, 2016

Resembling the behaviour of the app menu, the user menu now closes on ctrl+click and does not show the loading spinner.

Fixes #616

core/js/js.js Outdated
$page.find('img').remove();
$page.find('div').remove(); // prevent odd double-clicks
$page.prepend($('<div/>').addClass('icon-loading-small-dark'));
if(!event.ctrlKey) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On OS X this is event.metaKey could you also check for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also adjust the other menu too :)

@icewind1991
Copy link
Member

How about middle mousebutton?

@MorrisJobke
Copy link
Member

How about middle mousebutton?

On a trackpad there is no middle mousebutton 😝

@Faldon Thanks! Works really nice now :)

@MorrisJobke
Copy link
Member

👍

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jul 29, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Jul 29, 2016
@schiessle
Copy link
Member

schiessle commented Jul 29, 2016

On a trackpad there is no middle mousebutton

Not everyone uses a trackpad and some people have a well configured trackpack, e.g. I can do a middle click by tapping with three fingers 😉

Also it is not a either or... I would love if we could extend the behavior for middle click as well. @Faldon do you think you can add this? Thanks!

Frédéric LIETART and others added 2 commits July 29, 2016 22:33
@Faldon
Copy link
Contributor Author

Faldon commented Jul 29, 2016

Will look at it tomorrow. ;-)

@rullzer
Copy link
Member

rullzer commented Aug 5, 2016

See: #752

nextcloud-bot and others added 6 commits August 6, 2016 00:10
Includes PNG (16x16px) and SVG (scoured) versions in black, to be uniform with the other icon files.
…eateUser

Apply password policy on user creation
Disbale failing intergration test for now
@juliusknorr
Copy link
Member

#752 is merged, @Faldon could you rebase your pullrequest?

@Faldon
Copy link
Contributor Author

Faldon commented Aug 8, 2016

I hope this was right -.-

@MorrisJobke
Copy link
Member

I hope this was right -.-

Doesn't seem so. Should I create a new PR with only your changes?

@MorrisJobke
Copy link
Member

I tried to resolve this here: #778

@jancborchardt
Copy link
Member

Closing in favor of that new PR then.

R0Wi pushed a commit to R0Wi/server that referenced this pull request Nov 22, 2025
…ions/shivammathur/setup-php-2.35.4

chore(deps): Bump shivammathur/setup-php from 2.25.4 to 2.35.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ctrl-click on entries in the user menu will keep spinner spinning