-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fixing infinite spinning animation on user menu ctrl+click #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…extcloud#25301) * Fix file permissions for SMB (read-only folders will be writeable) * Read-only folders won't be deletable * Added comment for the read-only behaviour for folders
* Adding quota plugin to new dav endpoint * Added integrated test failing in old endpoint * Added 0B quota test
Signed-off-by: Stefan Weil <[email protected]>
…ster [upstream] Adding quota plugin to new dav endpoint
Fix misspelling of database "READ COMMITTED"
core/js/js.js
Outdated
| $page.find('img').remove(); | ||
| $page.find('div').remove(); // prevent odd double-clicks | ||
| $page.prepend($('<div/>').addClass('icon-loading-small-dark')); | ||
| if(!event.ctrlKey) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On OS X this is event.metaKey could you also check for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also adjust the other menu too :)
|
How about middle mousebutton? |
On a trackpad there is no middle mousebutton 😝 @Faldon Thanks! Works really nice now :) |
|
👍 |
up the minimum size of the public share video a bit, use 16/9 ratio
Dark hackery to not always disable CSRF for OCS controllers
Change app menu to white background with dark icons
Not everyone uses a trackpad and some people have a well configured trackpack, e.g. I can do a middle click by tapping with three fingers 😉 Also it is not a either or... I would love if we could extend the behavior for middle click as well. @Faldon do you think you can add this? Thanks! |
Change transifex link Owncloud > Nextcloud
|
Will look at it tomorrow. ;-) |
Transifex Owncloud > Nextcloud
|
See: #752 |
Includes PNG (16x16px) and SVG (scoured) versions in black, to be uniform with the other icon files.
…eateUser Apply password policy on user creation
Design fixes for updates
Disbale failing intergration test for now
…work OCS Share API to appframework
…ster Increment the versions and adjust the capitilization
…and-gif Also cache WOFF, SVG and GIF
Add black version of system tags icon
Added proper handling of primary mouse button click with and without ctrl-/meta-key modifier. Added handlig of middle mouse button click.
|
I hope this was right -.- |
Doesn't seem so. Should I create a new PR with only your changes? |
|
I tried to resolve this here: #778 |
|
Closing in favor of that new PR then. |
…ions/shivammathur/setup-php-2.35.4 chore(deps): Bump shivammathur/setup-php from 2.25.4 to 2.35.4
Resembling the behaviour of the app menu, the user menu now closes on ctrl+click and does not show the loading spinner.
Fixes #616