Dedicated connection warning icon

[nickvergessen]

• Red https://materialdesignicons.com/icon/network-strength-2-alert
• Pin to the right in the controls section
• Show tooltip on this icon
• Add button to disable video/screenshare if applicable

Use:

diff --git a/src/components/CallView/shared/LocalVideo.vue b/src/components/CallView/shared/LocalVideo.vue
index 317b113d0..cfacbb433 100644
--- a/src/components/CallView/shared/LocalVideo.vue
+++ b/src/components/CallView/shared/LocalVideo.vue
@@ -176,18 +175,21 @@ export default {
                },
 
                senderConnectionQualityAudioIsBad() {
+                       return true
                        return callAnalyzer
                                && (callAnalyzer.attributes.senderConnectionQualityAudio === CONNECTION_QUALITY.VERY_BAD
                                 || callAnalyzer.attributes.senderConnectionQualityAudio === CONNECTION_QUALITY.NO_TRANSMITTED_DATA)
                },
 
                senderConnectionQualityVideoIsBad() {
+                       return true
                        return callAnalyzer
                                && (callAnalyzer.attributes.senderConnectionQualityVideo === CONNECTION_QUALITY.VERY_BAD
                                 || callAnalyzer.attributes.senderConnectionQualityVideo === CONNECTION_QUALITY.NO_TRANSMITTED_DATA)
                },
 
                senderConnectionQualityScreenIsBad() {
+                       return true
                        return callAnalyzer
                                && (callAnalyzer.attributes.senderConnectionQualityScreen === CONNECTION_QUALITY.VERY_BAD
                                 || callAnalyzer.attributes.senderConnectionQualityScreen === CONNECTION_QUALITY.NO_TRANSMITTED_DATA)

to simulate

[marcoambrosini]

Sorry for the commit mess @danxuliu 😅

[nickvergessen]

When everything is disabled (and the message thing pops up), the tooltip is showing empty with a button with empty label.
Can we also just check if there is a message before showing the tooltip, or have a default message?

[danxuliu]

I have made some changes as discussed with @ma12-co (remove the dimming, as it was added to replace the icon, but as now there is an icon it is no longer needed; add a shadow to the quality warning icon; unify the tooltip messages (by reverting the split); other minor changes).

[danxuliu]

Tested and seems to work 👍

While testing the tooltip was shown again when screen sharing even after having dismissed it. I have no idea why and I have not been able to reproduce, it only happened once 🤷

[danxuliu]

/backport to stable19

[danxuliu]

While testing the tooltip was shown again when screen sharing even after having dismissed it. I have no idea why and I have not been able to reproduce, it only happened once 🤷

The issue seems to be that the LocalVideo component is destroyed and created again when a screen is shared (it could be related to the number of participants, although I have not verified it), so the isQualityWarningTooltipDismissed attribute starts again with its default value, which is false.