Fix duplicated event listeners in ParticipantAnalyzer #3911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event listeners where not properly stopped when a Peer was set, so if the same Peer was set twice the listeners were duplicated, which in turn could lead to errors due to only one of them being removed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
Member
Author
|
/backport to stable19 |
nickvergessen
approved these changes
Jul 16, 2020
nickvergessen
deleted the
fix-duplicated-event-listeners-in-participantanalyzer
branch
Member
Author
|
/backport to stable19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3839
The event listeners where not properly stopped when a Peer was set, so if the same Peer was set twice the listeners were duplicated, which in turn could lead to errors due to only one of them being removed.
How to test
Result with this pull request
The call is started.
Result without this pull request
The call is not started. Browser console shows an error about calling
setAnalysisEnabledAudioon a null object.