Skip to content

Bug 1809195: Remove '-' from servicemonitor spec #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 19, 2020
Merged

Bug 1809195: Remove '-' from servicemonitor spec #385

openshift-merge-robot merged 1 commit into from
Jun 19, 2020

Conversation

@jottofar
Copy link
Contributor

@jottofar jottofar commented Jun 16, 2020

During modifications for
#358 a new first
line of spec was added and therefore next line should not contain '-'.

@jottofar
Remove '-' from servicemonitor spec
e4961a5 
During modifications for
openshift#358 a new first
line of spec was added and therefore next line should not contain '-'.
@wking
Copy link
Member

wking commented Jun 16, 2020

/lgtm
/retitle Bug 1809195: Remove '-' from servicemonitor spec

@sdodson
Copy link
Member

sdodson commented Jun 16, 2020

/refresh

@sdodson
Copy link
Member

sdodson commented Jun 16, 2020

/lgtm
per #385 (comment) wake up sleepy bot

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jottofar,sdodson,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2020
@sdodson
Copy link
Member

sdodson commented Jun 16, 2020

/retitle Bug 1809195: Remove '-' from servicemonitor spec

@openshift-ci-robot openshift-ci-robot changed the title Remove '-' from servicemonitor spec Bug 1809195: Remove '-' from servicemonitor spec Jun 16, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 16, 2020

@jottofar: This pull request references Bugzilla bug 1809195, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1809195: Remove '-' from servicemonitor spec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jun 17, 2020

Lots of Expected — Waiting for status to be reported out of Prow.

/refresh

@wking
Copy link
Member

wking commented Jun 17, 2020

Doesn't seem to have helped :/. Maybe:

/retest

@wking
Copy link
Member

wking commented Jun 17, 2020

e2e-aws:

$ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/385/pull-ci-openshift-cluster-version-operator-master-e2e-aws/1273066739206197248/build-log.txt | grep 'INFO: missing some targets' | tail -n1
Jun 17 02:21:34.370: INFO: missing some targets: [no match for map[job:cluster-version-operator] with health up and scrape URL ^http://.*/metrics$]

Looks like we need to bump the tests to allow https.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
This was referenced Jun 17, 2020
Merged
Merged
@wking
Copy link
Member

wking commented Jun 18, 2020

/hold cancel
/retest

openshift/origin#25134 landed.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@jottofar
Copy link
Contributor Author

jottofar commented Jun 19, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2b84929 into openshift:master Jun 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 19, 2020

@jottofar: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1809195: Remove '-' from servicemonitor spec

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jottofar @wking @sdodson @openshift-ci-robot @openshift-bot @openshift-merge-robot