Bug 1809195: test/extended/prometheus: During transition, allow HTTP(S) for CVO #25134
Conversation
Currently the master CVO serves only HTTP. There is a pull request in flight (linked from the Go comment) to declare an HTTPS target in the ServiceMonitor. Allowing both, as I'm doing in this commit, will allow us to land this test-suite change now. Then we can land the CVO pull request. And then we can drop the '?' to require HTTPS going forward.
openshift-ci-robot
added
bugzilla/severity-high
|
@wking: This pull request references Bugzilla bug 1809195, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Currently the master CVO serves only HTTP. There is a pull request in flight (openshift/cluster-version-operator#385) to declare an HTTPS target in the ServiceMonitor. Allowing both, as I'm doing in this commit, will allow us to land this test-suite change now. Then we can land the CVO pull request. And then we can drop the '?' to require HTTPS going forward.