Skip to content

bug 1797788: add openshift-tests as a future delegation binary #24450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deads2k wants to merge 5 commits into from
Closed

bug 1797788: add openshift-tests as a future delegation binary #24450

deads2k wants to merge 5 commits into from

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 23, 2020

Let's learn about images!

This eases me into openshift/enhancements#185 by trying to get the image builds in order first.

  1. tests-base - includes openshift-tests which is now an execve call and will later be a binary union
  2. tests - builds on tests-base, includes openshift-test-kubernetes which is the same as the previous openshift-tests
  3. tests-kubernetes - the same as 2 right now, but eventually tests will be built out of openshift/openshift-tests instead.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 23, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Jan 23, 2020 •
edited
Loading

disappointing that github didn't render the straight move as I would have liked

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020
@deads2k deads2k force-pushed the union-openshift-tests branch from b083bdc to e18ac5e Compare January 27, 2020 15:36
@deads2k
Copy link
Contributor Author

deads2k commented Jan 27, 2020

/retest

@deads2k deads2k force-pushed the union-openshift-tests branch 2 times, most recently from 267511a to b62e9c5 Compare January 28, 2020 20:44
@deads2k
Copy link
Contributor Author

deads2k commented Jan 29, 2020

/test all

@deads2k deads2k force-pushed the union-openshift-tests branch 2 times, most recently from 0fa62a5 to 9b62b92 Compare February 3, 2020 18:02
@deads2k
Copy link
Contributor Author

deads2k commented Feb 3, 2020

/retest

@deads2k deads2k force-pushed the union-openshift-tests branch from 9b62b92 to f04a313 Compare February 3, 2020 19:43
@deads2k deads2k force-pushed the union-openshift-tests branch from f04a313 to 18c3abf Compare February 3, 2020 21:09
@deads2k deads2k changed the title add openshift-tests as a future delegation binary bug 1797788: add openshift-tests as a future delegation binary Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 3, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 3, 2020

@deads2k: This pull request references Bugzilla bug 1797788, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

bug 1797788: add openshift-tests as a future delegation binary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 4, 2020

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2020

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit 18c3abf link /test unit
ci/prow/e2e-gcp 18c3abf link /test e2e-gcp
ci/prow/e2e-aws-serial 18c3abf link /test e2e-aws-serial
ci/prow/e2e-cmd 18c3abf link /test e2e-cmd
ci/prow/e2e-gcp-upgrade 18c3abf link /test e2e-gcp-upgrade
ci/prow/e2e-aws-fips 18c3abf link /test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@deads2k wanna rebase this?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2020

@deads2k: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Feb 13, 2020

/uncc

@openshift-ci-robot openshift-ci-robot removed the request for review from sdodson February 13, 2020 15:33
This was referenced Feb 16, 2020
Closed
Closed
Merged
@soltysh
Copy link
Contributor

soltysh commented Feb 18, 2020

Closing in favor of #24560
/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2020

@soltysh: Closed this PR.

Details

In response to this:

Closing in favor of #24560
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deads2k @openshift-ci-robot @sdodson @soltysh