Skip to content

Conversation

@dlom
Copy link
Contributor

@dlom dlom commented Nov 23, 2022

This PR adds re-adds the functionality that was reverted in #1914, additionally adding some logs to better capture what's really going on in the stage environment. There are 2 more subsequent related PRs:

These PRs are supersets of this PR and contain the same commit SHAs. They should be merged in order.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2022
@dlom dlom force-pushed the HIVE-2038-again branch 2 times, most recently from 606625e to c41bf14 Compare November 30, 2022 19:17
@dlom dlom marked this pull request as ready for review November 30, 2022 19:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
@openshift-ci openshift-ci bot requested review from 2uasimojo and suhanime November 30, 2022 19:19
@dlom dlom changed the title WIP Syncset Testing PR #1 Nov 30, 2022
@dlom
Copy link
Contributor Author

dlom commented Nov 30, 2022

/assign @2uasimojo

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #1921 (8706081) into master (a24b27f) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1921   +/-   ##
=======================================
  Coverage   42.15%   42.16%           
=======================================
  Files         366      366           
  Lines       34045    34055   +10     
=======================================
+ Hits        14353    14358    +5     
- Misses      18485    18491    +6     
+ Partials     1207     1206    -1     
Impacted Files Coverage Δ
...g/controller/clustersync/clustersync_controller.go 75.38% <71.42%> (-0.40%) ⬇️

@dlom
Copy link
Contributor Author

dlom commented Dec 1, 2022

/retest

@dlom dlom mentioned this pull request Dec 1, 2022
@dlom
Copy link
Contributor Author

dlom commented Dec 1, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2022

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@2uasimojo
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d191451 into openshift:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants