-
Notifications
You must be signed in to change notification settings - Fork 253
Syncset Testing PR #1 #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncset Testing PR #1 #1921
Conversation
|
Skipping CI for Draft Pull Request. |
606625e to
c41bf14
Compare
|
/assign @2uasimojo |
c41bf14 to
d715028
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1921 +/- ##
=======================================
Coverage 42.15% 42.16%
=======================================
Files 366 366
Lines 34045 34055 +10
=======================================
+ Hits 14353 14358 +5
- Misses 18485 18491 +6
+ Partials 1207 1206 -1
|
|
/retest |
This reverts commit 8b5f056.
|
/retest |
|
@dlom: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds re-adds the functionality that was reverted in #1914, additionally adding some logs to better capture what's really going on in the stage environment. There are 2 more subsequent related PRs:
These PRs are supersets of this PR and contain the same commit SHAs. They should be merged in order.