This repository was archived by the owner on Sep 28, 2022. It is now read-only.
remove duplicate tests from openshift-tests-kubernetes #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
sallyom
force-pushed
the
remove-openshift-tests-kubernetes
branch
from
07a3ca4 to
e65ed83
Compare
This resource is new in 4.4 and is created by openshift-apiserver.
…pture the life of a replication controller"
We noticed a 2x CPU regression in e2e runs, and these are unfortunately the culprit.
It is expensive to perform 100 checks against 1k names on every startup. Instead, move these to generated files that can be reviewed out of bounds on change. Add them to generated-bindata for verification and regen.
Also move skip logic into provider initialization, and buffer a small amount of suite output. GCP tests are excluded from core infra, they are not used.
Change to use centos:7 which is more consistent.
Test that both ends of the range are available. Verify point to point connectivity across the whole cluster.
The --provider argument for openshift-tests accepts a string (the type) which triggers discovery, or JSON, which previously meant "use exactly these values". However, we have more tests which depend on logic from implicit fields (multimaster, region, zone, and number of nodes) that we don't want to have accidentally off. This was recently triggered when refactoring the methods in that numNodes was lost in CI, causing certain networking tests not to run. This commit changes openshift-tests run/run-upgrade to attempt to fill all fields of the config even when JSON is passed to --provider by invoking the cloud config load method, then updating provider for the subsequent exec'd test command so that it is accurate. The run-test command does not perform discovery, which forces the suite runner to be accurate.
The multi-node PV test creates a PV, starts a pod that writes data to a file on the PV, then kills the pod and starts another with node anti-affinity to read the data from the PV attached to a different node. This is problematic on multi-AZ clusters: there may only be one node in a zone and for volumes that can't be transferred among zones (AWS EBS, GCE PD, ...) the test would fail.
- Changes similar to openshift/origin@4a31327 as `--config` is deprecated and the replacement for the same is `--kubeconfig` - https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_jenkins/1015/pull-ci-openshift-jenkins-master-e2e-aws-jenkins/756 is a failed build where we are getting the error. ``` https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_jenkins/1015/pull-ci-openshift-jenkins-master-e2e-aws-jenkins/756 ``` - Updating this would allow for the Jenkins tests to be done by using the --kubeconfig flag with oc instead of --config
The recover is not necessary twice.
Signed-off-by: Sam Batschelet <[email protected]>
sallyom
force-pushed
the
remove-openshift-tests-kubernetes
branch
3 times, most recently
from
886f836 to
842bc8b
Compare
sallyom
force-pushed
the
remove-openshift-tests-kubernetes
branch
4 times, most recently
from
ec01345 to
218ad05
Compare
openshift-ci-robot
added
the
do-not-merge/invalid-owners-file
sallyom
force-pushed
the
remove-openshift-tests-kubernetes
branch
4 times, most recently
from
4561dc7 to
90ce9c9
Compare
sallyom
force-pushed
the
remove-openshift-tests-kubernetes
branch
from
90ce9c9 to
1cfa27b
Compare
|
The following users are mentioned in OWNERS file(s) but are not members of the openshift org. Once all users have been added as members of the org, you can trigger verification by writing
|
| reviewers: | ||
| - bparees | ||
| - pmorie | ||
| - jboyd01 |
Contributor
Author
There was a problem hiding this comment.
i copied this OWNERS from origin/examples. i'll check on it
Member
|
/test images |
1 similar comment
Member
|
/test images |
|
@sallyom: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
openshift-tests-kubernetes is going in a different direction, closing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registry.svc.ci.openshift.org/ocp/4.4:extended-platform-teststhat includes theopenshift-tests-kubernetes+extended-platform-testsbinaries - and for transition time also include theopenshift-testsbinary (this image will be renamed to become the release:tests image and theopenshift-testsbinary will be removed)need to merge in this order:
bug 1797788: add openshift-tests as a future delegation binary origin#24450Bug 1797788: add openshift-tests as a future delegation binary origin#24560openshift-testsbinary from the image built in this repo.this is how i understand what needs to happen
/cc @deads2k