Bug 1797788: add openshift-tests as a future delegation binary #24560

sallyom · 2020-02-18T13:31:00Z

picking up #24450 to get it merged

openshift-ci-robot · 2020-02-18T13:31:06Z

@sallyom: This pull request references Bugzilla bug 1797788, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1797788: add openshift-tests as a future delegation binary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve

openshift-bot · 2020-02-18T15:33:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T15:46:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T16:38:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T17:17:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T17:56:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T18:10:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T20:19:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T21:11:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-19T07:49:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-19T08:02:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-19T09:58:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-19T10:25:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

soltysh · 2020-02-19T11:22:49Z

/retest

openshift-bot · 2020-02-19T12:08:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-19T15:11:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-19T15:11:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-19T15:11:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sallyom · 2020-03-27T03:35:30Z

/retest

jianzhangbjz · 2020-03-27T09:17:04Z

/retest

soltysh · 2020-03-27T10:55:10Z

cmd/openshift-tests/openshift-tests.go


 			testBinaryPath := filepath.Join(dir, f.Name())
-			if testBinaries.Has(testBinaryPath) {
+			isSymlink, err := evalSymlink(testBinaryPath)


I thought we want to de-duplicate those, just like @deads2k proposed on slack, no?

Yes, I'll figure out where/why the symlink is getting created. I looked at the Dockerfiles but it's not coming from there 🤷‍♀️

sallyom · 2020-03-27T18:38:14Z

/retest

jianzhangbjz · 2020-03-30T01:31:12Z

/test e2e-gcp-upgrade

soltysh

/lgtm
/hold cancel

openshift-ci-robot · 2020-03-30T19:16:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-03-30T19:20:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-30T19:46:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-30T20:38:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-30T20:51:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-30T22:08:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-30T23:52:07Z

@sallyom: Some pull requests linked via external trackers have merged: openshift/origin#24560. The following pull requests linked via external trackers have not merged:

openshift/origin#24450 is closed
Bugzilla bug 1797788 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1797788: add openshift-tests as a future delegation binary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned soltysh Feb 18, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 18, 2020

openshift-ci-robot requested review from JacobTanenbaum and pweil- February 18, 2020 13:32

soltysh mentioned this pull request Feb 18, 2020

bug 1797788: add openshift-tests as a future delegation binary #24450

Closed

soltysh approved these changes Feb 18, 2020

View reviewed changes

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2020

This was referenced Feb 18, 2020

remove duplicate tests from openshift-tests-kubernetes openshift/openshift-tests#12

Closed

add template to run extended-platform-tests image openshift/release#7190

Closed

sallyom mentioned this pull request Feb 18, 2020

add tests-kubernetes image build outside of tests image openshift/release#7215

Closed

sallyom force-pushed the deads2k-union-openshift-tests branch from 42bcce4 to 7a794f0 Compare March 26, 2020 20:21

soltysh suggested changes Mar 27, 2020

View reviewed changes

sallyom force-pushed the deads2k-union-openshift-tests branch from 7a794f0 to c6d0eeb Compare March 27, 2020 12:27

deads2k and others added 8 commits March 30, 2020 09:44

move existing openshift tests to openshift-tests-kubernetes

f86082d

add openshift-tests as a future delegation binary

b41307a

add openshift-tests-kubernetes image

551e25f

build openshift-tests in one image to phase in new images

5753b6e

switch to looking up all test plugins

e66b34d

fix etcd_storage_path test, clean up all crds

9be3013

spelling exectuable/executable

9dffdea

remove duplicate tests plugins from symlinks

42ca787

sallyom force-pushed the deads2k-union-openshift-tests branch from c6d0eeb to 42ca787 Compare March 30, 2020 13:48

soltysh approved these changes Mar 30, 2020

View reviewed changes

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 30, 2020

openshift-merge-robot merged commit 7a8399e into openshift:master Mar 30, 2020

smarterclayton mentioned this pull request Mar 31, 2020

Revert "Bug 1797788: add openshift-tests as a future delegation binary" #24805

Closed

mandre mentioned this pull request Apr 1, 2020

OpenStack: fix binaries in test image openshift/release#8065

Merged

openshift-ci-robot mentioned this pull request Apr 1, 2020

Revert "Bug 1797788: add openshift-tests as a future delegation binary" #24808

Merged

Bug 1797788: add openshift-tests as a future delegation binary #24560

Bug 1797788: add openshift-tests as a future delegation binary #24560

Uh oh!

Conversation

sallyom commented Feb 18, 2020

Uh oh!

openshift-ci-robot commented Feb 18, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 18, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

soltysh commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

openshift-bot commented Feb 19, 2020

Uh oh!

sallyom commented Mar 27, 2020

Uh oh!

jianzhangbjz commented Mar 27, 2020

Uh oh!

soltysh Mar 27, 2020

Choose a reason for hiding this comment

Uh oh!

sallyom Mar 27, 2020

Choose a reason for hiding this comment

Uh oh!

sallyom commented Mar 27, 2020

Uh oh!

jianzhangbjz commented Mar 30, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 30, 2020

Uh oh!

openshift-bot commented Mar 30, 2020

Uh oh!

openshift-bot commented Mar 30, 2020

Uh oh!

openshift-bot commented Mar 30, 2020

Uh oh!

openshift-bot commented Mar 30, 2020

Uh oh!

openshift-bot commented Mar 30, 2020

Uh oh!

openshift-ci-robot commented Mar 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects