Skip to content

Revert "Bug 1797788: add openshift-tests as a future delegation binary" #24808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smarterclayton merged 1 commit into from
Apr 1, 2020
Merged

Revert "Bug 1797788: add openshift-tests as a future delegation binary" #24808

smarterclayton merged 1 commit into from
Apr 1, 2020

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Mar 31, 2020

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2020

@smarterclayton: This pull request references Bugzilla bug 1797788, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Revert "Bug 1797788: add openshift-tests as a future delegation binary"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 31, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Mar 31, 2020

/retest

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Mar 31, 2020

I'm going to revert this for now while we sort out options - I had some larger concerns that there may be an alternative direction on.

@smarterclayton smarterclayton mentioned this pull request Mar 31, 2020
Closed
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Mar 31, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Apr 1, 2020

/test e2e-gcp-upgrade

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Apr 1, 2020

/refresh

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Apr 1, 2020

/test e2e-gcp-upgrade

1 similar comment
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Apr 1, 2020

/test e2e-gcp-upgrade

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Apr 1, 2020

/cc

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Apr 1, 2020

Master is flaky due to dockercfg secret, direct merging to get tests in better shape. Passed all tests and batch tests at least once.

@smarterclayton smarterclayton merged commit 1496fba into openshift:master Apr 1, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2020

@smarterclayton: Some pull requests linked via external trackers have merged: openshift/origin#24808, openshift/origin#24560. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Revert "Bug 1797788: add openshift-tests as a future delegation binary"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@pweil- pweil- Awaiting requested review from pweil-

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smarterclayton @openshift-ci-robot @openshift-bot @jianzhangbjz