refactor(language_server): set `null` as a default value for `configPath` #10047

Sysix · 2025-03-25T21:20:44Z

nothing should change because nested config is disabled with disable_nested_config

Sysix · 2025-03-25T21:21:01Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-03-25T21:27:17Z

CodSpeed Instrumentation Performance Report

Merging #10047 will not alter performance

_{Comparing 03-25-refactor_language_server_enable_nested_configuration_by_default (c0e5251) with main (6687f5b)}

Summary

✅ 33 untouched benchmarks

editors/vscode/client/Config.ts

camchenry · 2025-03-28T04:29:34Z

Merge activity

Mar 28, 12:29 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 28, 12:29 AM EDT: camchenry added this pull request to the Graphite merge queue.
Mar 28, 1:27 AM EDT: A user merged this pull request with the Graphite merge queue.

…ath` (#10047) nothing should change because nested config is disabled with `disable_nested_config`

bug introduced in #10047. Reenable default `.oxlintrc.json` file watcher when no config path is provided

## [0.16.4] - 2025-04-01 - da6336c language_server: [**BREAKING**] Remove `enable` configuration, the client should shutdown the server instead (#9990) (Sysix) ### Features - 06e3db9 linter: Support `multipleFileExtensions` option for `unicorn/filename-case` (#10118) (shulaoda) - dbe0e46 linter: Support `ignore` option for `unicorn/filename-case` (#10107) (shulaoda) ### Bug Fixes - 0a33e27 editor: Update `initializationOptions` for a possible restart (#10121) (Sysix) - ac780a2 editor: Repair filewatchers when no custom config provided (#10104) (Sysix) - 4303ace editor: Dont send `didChangeConfiguration` request to the server when it is shutdown (#10084) (Sysix) - 07f2a25 editor: Enable regex parsing in language server (#10035) (camchenry) - fcf7702 language_server: Start from a default oxlint configuration + SafeFix for nested configuration (#10043) (Sysix) - aba3654 linter: Span disable directive correctly on next line (#10141) (Ulrich Stark 🦀) - 2c80858 linter: Enable multi-file analysis for nested configs (#10089) (camchenry) ### Performance - 566be59 linter: Replace `phf_set` with `array` in `eslint/func-names` (#10119) (shulaoda) - 5e14fe9 linter: Inline `PRE_DEFINE_VAR` and use `array` format (#10079) (shulaoda) ### Refactor - 327be53 editor: `LanguageClient` can be undefined (#10112) (Sysix) - 5ec477c editor: Make `onConfigChange` async (#10110) (Sysix) - a278d73 editor: Use warning background when the plugin is deactived (#10085) (Sysix) - c0e5251 language_server: Set `null` as a default value for `configPath` (#10047) (Sysix) - 09c0ac6 linter: Improve `unicorn/filename-case` (#10117) (shulaoda) - d8e49a1 linter: Compute lintable extensions at compile time (#10090) (camchenry) - b3ec235 linter: Use items of `oxc_ast::ast` module directly (#10100) (Ulrich Stark 🦀) - 93e6c0b linter: Use `FormalParameter::has_modifier` to detect parameter properties (#10097) (Ulrich Stark 🦀) - 5d829c2 semantic: Align handling of declaring symbol for function with TypeScript (#10086) (Dunqing) ### Testing - 410b8d6 editor: Use debug build of the language server (#10083) (Sysix) - 500add0 editor: Add test for `oxc.fixAll` command (#10045) (Sysix) Co-authored-by: Boshen <[email protected]>

This was referenced Mar 25, 2025

refactor(language_server)!: remove enable configuration, the client should shutdown the server instead #9990

Merged

fix(language_server): start from a default oxlint configuration + SafeFix for nested configuration #10043

Merged

Sysix mentioned this pull request Mar 25, 2025

test(editor): add test for oxc.fixAll command #10045

Merged

github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 25, 2025

Sysix force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from 4084183 to af43f54 Compare March 25, 2025 21:22

Sysix force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from af43f54 to 986c9dc Compare March 25, 2025 21:27

Sysix marked this pull request as ready for review March 25, 2025 21:33

Sysix requested a review from nrayburn-tech March 25, 2025 21:33

Sysix force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from 986c9dc to 34d7440 Compare March 25, 2025 21:41

Sysix changed the title ~~refactor(language_server)!: enable nested configuration by default~~ refactor(language_server): set null as a default value for configPath Mar 25, 2025

graphite-app bot force-pushed the 03-23-refactor_language_server_remove_enabled_configuration_the_client_should_shutdown_the_server_instead branch from d5bb285 to 34814c8 Compare March 26, 2025 01:55

graphite-app bot force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from 34d7440 to 6f2353b Compare March 26, 2025 01:55

camchenry reviewed Mar 26, 2025

View reviewed changes

editors/vscode/client/Config.ts Outdated Show resolved Hide resolved

graphite-app bot changed the base branch from 03-23-refactor_language_server_remove_enabled_configuration_the_client_should_shutdown_the_server_instead to graphite-base/10047 March 26, 2025 17:35

graphite-app bot force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from 6f2353b to dde1f69 Compare March 26, 2025 17:43

graphite-app bot force-pushed the graphite-base/10047 branch from 34814c8 to da6336c Compare March 26, 2025 17:43

graphite-app bot changed the base branch from graphite-base/10047 to main March 26, 2025 17:44

graphite-app bot force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from dde1f69 to b1fb1b6 Compare March 26, 2025 17:44

Sysix force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from b1fb1b6 to 396df64 Compare March 26, 2025 20:16

camchenry approved these changes Mar 28, 2025

View reviewed changes

camchenry added the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025

refactor(language_server): set null as a default value for `configP…

c0e5251

…ath` (#10047) nothing should change because nested config is disabled with `disable_nested_config`

graphite-app bot force-pushed the 03-25-refactor_language_server_enable_nested_configuration_by_default branch from 396df64 to c0e5251 Compare March 28, 2025 05:09

graphite-app bot merged commit c0e5251 into main Mar 28, 2025
31 checks passed

graphite-app bot deleted the 03-25-refactor_language_server_enable_nested_configuration_by_default branch March 28, 2025 05:27

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025

Sysix mentioned this pull request Mar 28, 2025

fix(editor): repair filewatchers when no custom config provided #10104

Merged

graphite-app bot pushed a commit that referenced this pull request Mar 29, 2025

fix(editor): repair filewatchers when no custom config provided (#10104)

ac780a2

bug introduced in #10047. Reenable default `.oxlintrc.json` file watcher when no config path is provided

oxc-bot mentioned this pull request Apr 1, 2025

release(oxlint): v0.16.4 #10155

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(language_server): set `null` as a default value for `configPath` #10047

refactor(language_server): set `null` as a default value for `configPath` #10047

Uh oh!

Sysix commented Mar 25, 2025 •

edited

Loading

Uh oh!

Sysix commented Mar 25, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

camchenry commented Mar 28, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(language_server): set null as a default value for configPath #10047

refactor(language_server): set null as a default value for configPath #10047

Uh oh!

Conversation

Sysix commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10047 will not alter performance

Summary

Uh oh!

Uh oh!

camchenry commented Mar 28, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(language_server): set `null` as a default value for `configPath` #10047

refactor(language_server): set `null` as a default value for `configPath` #10047

Sysix commented Mar 25, 2025 •

edited

Loading

Sysix commented Mar 25, 2025 •

edited

Loading

codspeed-hq bot commented Mar 25, 2025 •

edited

Loading

camchenry commented Mar 28, 2025 •

edited by graphite-app bot

Loading