refactor(semantic): align handling of declaring symbol for function with TypeScript #10086

Dunqing · 2025-03-28T00:59:30Z

The Symbol is based on the TypeScript implementation, but TypeScript doesn't support non-strict mode. So we tweaked the implementation to support non-strict mode before, but that held us back from adding symbol id for declare function, because declare function oxc(): number; declare function oxc(): void is valid, but we have no idea except introducing more symbol flags by to check whether it is a declare function. But introducing more symbol flags will lead to greater discrepancies between our implementation and TypeScript. #10074 has re-implemented the function redeclaration check in checker so that this PR can make a change to align with TypeScript implementation without leading to unexpected errors.

A lot of error messages are removed in snapshots, because they are all duplicated, which was introduced by #10074

Dunqing · 2025-03-28T00:59:54Z

feat(semantic): add symbol_id for declare class binding #10095
refactor(semantic): align handling of declaring symbol for class with TypeScript #10094
feat(semantic): check redeclaration of function declaration and class declaration #10093
feat(semantic): add symbol_id for declare function binding #10078
refactor(semantic): align handling of declaring symbol for function with TypeScript #10086 👈 (View in Graphite)
feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074
fix(semantic): define a variable in a function expression whose name is the same as the function name which is considered a redeclaration #10077
refactor(semantic)!: store symbol information as the first entry in symbol_declarations when it is redeclared #10062
feat(semantic/scoping): add declaration and flags fields for Redeclaraion #10060
feat(semantic): introduce Redeclaraion for Scoping::symbol_declarations #10059
perf(semantic): use FxHashMap to replace IndexVec for symbol_redeclarations #10058
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-03-28T01:07:31Z

CodSpeed Instrumentation Performance Report

Merging #10086 will not alter performance

_{Comparing 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript (5d829c2) with main (2720204)}

Summary

✅ 33 untouched benchmarks

Boshen · 2025-03-28T04:11:46Z

Merge activity

Mar 28, 12:11 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 28, 3:25 AM EDT: Boshen added this pull request to the Graphite merge queue.
Mar 28, 3:44 AM EDT: A user merged this pull request with the Graphite merge queue.

…ith TypeScript (#10086) The `Symbol` is based on the `TypeScript` implementation, but `TypeScript` doesn't support non-strict mode. So we tweaked the implementation to support non-strict mode before, but that held us back from adding symbol id for `declare function`, because `declare function oxc(): number; declare function oxc(): void` is valid, but we have no idea except introducing more symbol flags by to check whether it is a declare function. But introducing more symbol flags will lead to greater discrepancies between our implementation and `TypeScript`. #10074 has re-implemented the function redeclaration check in `checker` so that this PR can make a change to align with `TypeScript` implementation without leading to unexpected errors. A lot of error messages are removed in snapshots, because they are all duplicated, which was introduced by #10074

…th TypeScript (#10094) Same as #10086 but for `class`

## [0.16.4] - 2025-04-01 - da6336c language_server: [**BREAKING**] Remove `enable` configuration, the client should shutdown the server instead (#9990) (Sysix) ### Features - 06e3db9 linter: Support `multipleFileExtensions` option for `unicorn/filename-case` (#10118) (shulaoda) - dbe0e46 linter: Support `ignore` option for `unicorn/filename-case` (#10107) (shulaoda) ### Bug Fixes - 0a33e27 editor: Update `initializationOptions` for a possible restart (#10121) (Sysix) - ac780a2 editor: Repair filewatchers when no custom config provided (#10104) (Sysix) - 4303ace editor: Dont send `didChangeConfiguration` request to the server when it is shutdown (#10084) (Sysix) - 07f2a25 editor: Enable regex parsing in language server (#10035) (camchenry) - fcf7702 language_server: Start from a default oxlint configuration + SafeFix for nested configuration (#10043) (Sysix) - aba3654 linter: Span disable directive correctly on next line (#10141) (Ulrich Stark 🦀) - 2c80858 linter: Enable multi-file analysis for nested configs (#10089) (camchenry) ### Performance - 566be59 linter: Replace `phf_set` with `array` in `eslint/func-names` (#10119) (shulaoda) - 5e14fe9 linter: Inline `PRE_DEFINE_VAR` and use `array` format (#10079) (shulaoda) ### Refactor - 327be53 editor: `LanguageClient` can be undefined (#10112) (Sysix) - 5ec477c editor: Make `onConfigChange` async (#10110) (Sysix) - a278d73 editor: Use warning background when the plugin is deactived (#10085) (Sysix) - c0e5251 language_server: Set `null` as a default value for `configPath` (#10047) (Sysix) - 09c0ac6 linter: Improve `unicorn/filename-case` (#10117) (shulaoda) - d8e49a1 linter: Compute lintable extensions at compile time (#10090) (camchenry) - b3ec235 linter: Use items of `oxc_ast::ast` module directly (#10100) (Ulrich Stark 🦀) - 93e6c0b linter: Use `FormalParameter::has_modifier` to detect parameter properties (#10097) (Ulrich Stark 🦀) - 5d829c2 semantic: Align handling of declaring symbol for function with TypeScript (#10086) (Dunqing) ### Testing - 410b8d6 editor: Use debug build of the language server (#10083) (Sysix) - 500add0 editor: Add test for `oxc.fixAll` command (#10045) (Sysix) Co-authored-by: Boshen <[email protected]>

github-actions bot added A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 28, 2025

Dunqing mentioned this pull request Mar 28, 2025

feat(semantic): add symbol_id for declare function binding #10078

Merged

Dunqing marked this pull request as ready for review March 28, 2025 01:21

Dunqing requested a review from Boshen as a code owner March 28, 2025 01:21

Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from e81ae1e to 50b2970 Compare March 28, 2025 04:29

graphite-app bot requested a review from overlookmotel as a code owner March 28, 2025 04:29

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 50b2970 to dde0a96 Compare March 28, 2025 04:30

graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch from c29f055 to 132631b Compare March 28, 2025 04:30

Dunqing force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch from 132631b to 7116b2c Compare March 28, 2025 05:18

Dunqing force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from dde0a96 to 51660e6 Compare March 28, 2025 05:18

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 51660e6 to 0b5161c Compare March 28, 2025 07:25

graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch from 7116b2c to 98ac03b Compare March 28, 2025 07:26

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 0b5161c to 5f8c64c Compare March 28, 2025 07:27

github-actions bot added the A-cli Area - CLI label Mar 28, 2025

graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch from 98ac03b to 8376903 Compare March 28, 2025 07:28

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 5f8c64c to 370266c Compare March 28, 2025 07:32

graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch from 8376903 to 5d829c2 Compare March 28, 2025 07:33

Base automatically changed from 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope to main March 28, 2025 07:42

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025

graphite-app bot merged commit 5d829c2 into main Mar 28, 2025
26 checks passed

graphite-app bot deleted the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch March 28, 2025 07:44

graphite-app bot pushed a commit that referenced this pull request Mar 29, 2025

refactor(semantic): align handling of declaring symbol for class wi…

dc3602c

…th TypeScript (#10094) Same as #10086 but for `class`

oxc-bot mentioned this pull request Apr 1, 2025

release(oxlint): v0.16.4 #10155

Merged

oxc-bot mentioned this pull request Apr 1, 2025

release(crates): v0.62.0 #10158

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(semantic): align handling of declaring symbol for function with TypeScript #10086

refactor(semantic): align handling of declaring symbol for function with TypeScript #10086

Uh oh!

Dunqing commented Mar 28, 2025 •

edited by Boshen

Loading

Uh oh!

Dunqing commented Mar 28, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

Boshen commented Mar 28, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(semantic): align handling of declaring symbol for function with TypeScript #10086

refactor(semantic): align handling of declaring symbol for function with TypeScript #10086

Uh oh!

Conversation

Dunqing commented Mar 28, 2025 • edited by Boshen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10086 will not alter performance

Summary

Uh oh!

Boshen commented Mar 28, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Dunqing commented Mar 28, 2025 •

edited by Boshen

Loading

Dunqing commented Mar 28, 2025 •

edited

Loading

codspeed-hq bot commented Mar 28, 2025 •

edited

Loading

Boshen commented Mar 28, 2025 •

edited by graphite-app bot

Loading