fix(linter): span disable directive correctly on next line #10141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Instrumentation Performance ReportMerging #10141 will degrade performances by 3.74%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
Just converted this PR to draft because I think some tests won't hurt |
ulrichstark
force-pushed
the
span-disable-directly-correctly-on-next-line
branch
from
09e7d3b to
27c36c1
Compare
Boshen
reviewed
Apr 1, 2025
Boshen
added a commit
that referenced
this pull request
Apr 1, 2025
## [0.16.4] - 2025-04-01 - da6336c language_server: [**BREAKING**] Remove `enable` configuration, the client should shutdown the server instead (#9990) (Sysix) ### Features - 06e3db9 linter: Support `multipleFileExtensions` option for `unicorn/filename-case` (#10118) (shulaoda) - dbe0e46 linter: Support `ignore` option for `unicorn/filename-case` (#10107) (shulaoda) ### Bug Fixes - 0a33e27 editor: Update `initializationOptions` for a possible restart (#10121) (Sysix) - ac780a2 editor: Repair filewatchers when no custom config provided (#10104) (Sysix) - 4303ace editor: Dont send `didChangeConfiguration` request to the server when it is shutdown (#10084) (Sysix) - 07f2a25 editor: Enable regex parsing in language server (#10035) (camchenry) - fcf7702 language_server: Start from a default oxlint configuration + SafeFix for nested configuration (#10043) (Sysix) - aba3654 linter: Span disable directive correctly on next line (#10141) (Ulrich Stark 🦀) - 2c80858 linter: Enable multi-file analysis for nested configs (#10089) (camchenry) ### Performance - 566be59 linter: Replace `phf_set` with `array` in `eslint/func-names` (#10119) (shulaoda) - 5e14fe9 linter: Inline `PRE_DEFINE_VAR` and use `array` format (#10079) (shulaoda) ### Refactor - 327be53 editor: `LanguageClient` can be undefined (#10112) (Sysix) - 5ec477c editor: Make `onConfigChange` async (#10110) (Sysix) - a278d73 editor: Use warning background when the plugin is deactived (#10085) (Sysix) - c0e5251 language_server: Set `null` as a default value for `configPath` (#10047) (Sysix) - 09c0ac6 linter: Improve `unicorn/filename-case` (#10117) (shulaoda) - d8e49a1 linter: Compute lintable extensions at compile time (#10090) (camchenry) - b3ec235 linter: Use items of `oxc_ast::ast` module directly (#10100) (Ulrich Stark 🦀) - 93e6c0b linter: Use `FormalParameter::has_modifier` to detect parameter properties (#10097) (Ulrich Stark 🦀) - 5d829c2 semantic: Align handling of declaring symbol for function with TypeScript (#10086) (Dunqing) ### Testing - 410b8d6 editor: Use debug build of the language server (#10083) (Sysix) - 500add0 editor: Add test for `oxc.fixAll` command (#10045) (Sysix) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code didn't account for the newline characters (0..N carriage return characters and one line feed character) between the line of the disable directive comment and the next line.
Fixes #10115