-
-
Notifications
You must be signed in to change notification settings - Fork 781
perf(lexer): remove string allocation #11255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11255 will degrade performances by 12.08%Comparing Summary
Benchmarks breakdown
|
58615d2 to
5bc76b5
Compare
Merge activity
|
Small optimization. Remove unnecessary `ArenaString` allocation when decoding octal escape sequences. Also calculate the unescaped value at same time as reading the bytes from source, instead of decoding a 2nd time with `u32::from_str_radix`.
15f72a9 to
3281e99
Compare
5bc76b5 to
254048d
Compare

Small optimization. Remove unnecessary
ArenaStringallocation when decoding octal escape sequences. Also calculate the unescaped value at same time as reading the bytes from source, instead of decoding a 2nd time withu32::from_str_radix.