Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 23, 2025

Small optimization. Remove unnecessary ArenaString allocation when decoding octal escape sequences. Also calculate the unescaped value at same time as reading the bytes from source, instead of decoding a 2nd time with u32::from_str_radix.

Copy link
Member Author

overlookmotel commented May 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance labels May 23, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 23, 2025 19:58
@codspeed-hq
Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Instrumentation Performance Report

Merging #11255 will degrade performances by 12.08%

Comparing 05-23-perf_lexer_remove_string_allocation (254048d) with 05-23-perf_transformer_react-refresh_faster_base64_encoding (3281e99)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -12.08%

@overlookmotel overlookmotel changed the base branch from main to graphite-base/11255 May 24, 2025 00:03
@overlookmotel overlookmotel force-pushed the 05-23-perf_lexer_remove_string_allocation branch from 58615d2 to 5bc76b5 Compare May 24, 2025 00:03
@overlookmotel overlookmotel changed the base branch from graphite-base/11255 to 05-23-perf_transformer_react-refresh_faster_base64_encoding May 24, 2025 00:03
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 24, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 24, 2025

Merge activity

Small optimization. Remove unnecessary `ArenaString` allocation when decoding octal escape sequences. Also calculate the unescaped value at same time as reading the bytes from source, instead of decoding a 2nd time with `u32::from_str_radix`.
@graphite-app graphite-app bot force-pushed the 05-23-perf_transformer_react-refresh_faster_base64_encoding branch from 15f72a9 to 3281e99 Compare May 24, 2025 02:31
@graphite-app graphite-app bot requested a review from Dunqing as a code owner May 24, 2025 02:31
@graphite-app graphite-app bot force-pushed the 05-23-perf_lexer_remove_string_allocation branch from 5bc76b5 to 254048d Compare May 24, 2025 02:32
Base automatically changed from 05-23-perf_transformer_react-refresh_faster_base64_encoding to main May 24, 2025 02:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 24, 2025
@graphite-app graphite-app bot merged commit 254048d into main May 24, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 05-23-perf_lexer_remove_string_allocation branch May 24, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants