Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 24, 2025

Add Atom::from_strs_array_in method, to complement String::from_strs_array_in. In many places we were using String::from_strs_array_in only as a means to get an Atom. Cut out the middleman!

This prepares the way for #11260, and getting rid of String entirely.

Copy link
Member Author

overlookmotel commented May 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 24, 2025

CodSpeed Instrumentation Performance Report

Merging #11261 will improve performances by 13.52%

Comparing 05-24-feat_span_add_atom_from_strs_array_in_method (4feeeee) with 05-23-perf_lexer_remove_string_allocation (254048d)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.5 ms 3 ms +13.52%

@overlookmotel overlookmotel marked this pull request as ready for review May 24, 2025 00:34
@overlookmotel overlookmotel requested a review from Dunqing as a code owner May 24, 2025 00:34
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 24, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 24, 2025

Merge activity

Add `Atom::from_strs_array_in` method, to complement `String::from_strs_array_in`. In many places we were using `String::from_strs_array_in` only as a means to get an `Atom`. Cut out the middleman!

This prepares the way for #11260, and getting rid of `String` entirely.
@graphite-app graphite-app bot force-pushed the 05-23-perf_lexer_remove_string_allocation branch from 5bc76b5 to 254048d Compare May 24, 2025 02:32
@graphite-app graphite-app bot force-pushed the 05-24-feat_span_add_atom_from_strs_array_in_method branch from 91b20f5 to 4feeeee Compare May 24, 2025 02:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 24, 2025
Base automatically changed from 05-23-perf_lexer_remove_string_allocation to main May 24, 2025 02:38
@graphite-app graphite-app bot merged commit 4feeeee into main May 24, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 05-24-feat_span_add_atom_from_strs_array_in_method branch May 24, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants