refactor(transformer): use StringBuilder instead of String

[overlookmotel]

Replace usage of String with StringBuilder (introduced in #11257) in transformer.

[overlookmotel]

• refactor(allocator)!: remove String #11262
• refactor(transformer): use StringBuilder instead of String #11260 👈 (View in Graphite)
• refactor(parser): use StringBuilder instead of String #11259
• refactor(ast, span): use StringBuilder instead of String #11258
• feat(allocator): introduce StringBuilder #11257
• feat(span): add Atom::from_strs_array_in method #11261
• perf(lexer): remove string allocation #11255
• perf(transformer/react-refresh): faster base64 encoding #11254
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #11260 will improve performances by 29.52%

_{Comparing 05-23-refactor_transformer_use_stringbuilder_instead_of_string_ (202ffd2) with 05-23-refactor_parser_use_stringbuilder_instead_of_string_ (02d3bb7)}

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	mangler[cal.com.tsx]	3.5 ms	2.7 ms	+29.52%

[overlookmotel]

Oh bollocks! It's a -1% perf hit. Probably because main usage is generating UIDs, where we only use StringBuilder::from_strs_array_in which doesn't utilize StringBuilder's advantages, but receives its downsides. Should probably add Atom::from_strs_array_in for this use case, where you don't need any intermediate structure at all (no String or StringBuilder).

[overlookmotel]

The perf drop is now gone thanks to #11261 (or maybe it was just noise in benchmarks, hard to know). I did find from Godbolt that Atom::from_strs_array_in is a couple of instructions shorter than Atom::from(StringBuilder::from_strs_array_in)).

[graphite-app]

Merge activity

• May 24, 2:27 AM UTC: Boshen added this pull request to the Graphite merge queue.
• May 24, 2:43 AM UTC: Merged by the Graphite merge queue.