refactor(ast_codegen): remove unnecessary imports from generated files #4774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
CodSpeed Performance ReportMerging #4774 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
08-09-refactor_ast_oxc_ast_crate_re-export_ast_types_from_other_crates
branch
from
2b79f16 to
c697c35
Compare
overlookmotel
force-pushed
the
08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files
branch
from
d787af5 to
fb10b6d
Compare
This was referenced Aug 9, 2024
rzvxa
changed the base branch from
08-09-refactor_ast_oxc_ast_crate_re-export_ast_types_from_other_crates
to
graphite-base/4774
rzvxa
force-pushed
the
graphite-base/4774
branch
from
c697c35 to
daa0b2e
Compare
rzvxa
force-pushed
the
08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files
branch
from
fb10b6d to
87ed56b
Compare
Contributor
Merge activity
|
#4774) #4773 makes types like `Span` importable from `oxc_ast::ast`, so remove the imports from other crates in generated code. I'm not sure why clippy's `wildcard_imports` rule was not being triggered for `use crate::ast::*;`, but add `#[allow(clippy::wildcard_imports)]` on these statements just to make sure.
rzvxa
force-pushed
the
08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files
branch
from
87ed56b to
dbb5f4c
Compare
graphite-app
bot
deleted the
08-09-refactor_ast_codegen_remove_unnecessary_imports_from_generated_files
branch
This was referenced Aug 9, 2024
Merged
Boshen
added a commit
that referenced
this pull request
Aug 10, 2024
## [0.24.1] - 2024-08-10 ### Features - b3c3125 linter: Overhaul unicorn/no-useless-spread (#4791) (DonIsaac) - c519295 minifier: Add `InjectGlobalVariables` plugin (`@rollup/plugin-inject`) (#4759) (Boshen) ### Bug Fixes - fff9da3 ast, ast_codegen: Use `generate_derive` instead of visitable for generating span derives. (#4747) (rzvxa) - f5eeebd ast_macros: Raise compile error on invalid `generate_derive` input. (#4766) (rzvxa) - 4d0b40a napi/transform: Fix wrong isolated declarations emit (Boshen) ### Refactor - daa0b2e ast: `oxc_ast` crate re-export AST types from other crates (#4773) (overlookmotel) - d4a3be8 ast_codegen: Line breaks between types in layout assertions (#4781) (overlookmotel) - dbb5f4c ast_codegen: Remove unnecessary imports from generated files (#4774) (overlookmotel) - 7ea058d ast_codegen: Replace Windows-style line breaks with Unix-style (#4769) (overlookmotel) - 2dea0ca ast_codegen: Consistent import order (#4761) (overlookmotel) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4773 makes types like
Spanimportable fromoxc_ast::ast, so remove the imports from other crates in generated code.I'm not sure why clippy's
wildcard_importsrule was not being triggered foruse crate::ast::*;, but add#[allow(clippy::wildcard_imports)]on these statements just to make sure.