Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 9, 2024

Pure refactor. Just move code which is most used to top of fmt module. And rename pprint to pretty_print to be a little clearer.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel marked this pull request as ready for review August 9, 2024 06:55
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #4779 will not alter performance

Comparing 08-09-refactor_ast_codegen_re-order_code_in_fmt_module (966fcc9) with main (2c1c705)

Summary

✅ 29 untouched benchmarks

@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from 93546af to 9c53522 Compare August 9, 2024 07:20
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from 790dd61 to 080b84d Compare August 9, 2024 07:20
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from 9c53522 to a861c31 Compare August 9, 2024 07:33
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from a861c31 to 1e25ab5 Compare August 9, 2024 07:39
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from 080b84d to f3470bb Compare August 9, 2024 07:39
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from 1e25ab5 to 992f1cd Compare August 9, 2024 07:50
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from f3470bb to e126245 Compare August 9, 2024 07:50
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from 992f1cd to 2562cd7 Compare August 9, 2024 07:57
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from e126245 to 58bc0de Compare August 9, 2024 07:57
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ branch from 2562cd7 to e0d978c Compare August 9, 2024 08:22
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch 2 times, most recently from 94a6edc to 601ba35 Compare August 9, 2024 08:33
@overlookmotel overlookmotel changed the base branch from 08-09-refactor_ast_codegen_use_doc_comments_instead_of_endl_ to graphite-base/4779 August 9, 2024 08:57
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 9, 2024

Merge activity

  • Aug 9, 4:58 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 9, 4:58 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 9, 5:03 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Aug 9, 6:00 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 9, 6:01 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Aug 9, 6:08 AM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel changed the base branch from graphite-base/4779 to main August 9, 2024 09:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from 601ba35 to 7bf49b8 Compare August 9, 2024 09:57
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024
Pure refactor. Just move code which is most used to top of `fmt` module. And rename `pprint` to `pretty_print` to be a little clearer.
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch from 7bf49b8 to 966fcc9 Compare August 9, 2024 10:01
@graphite-app graphite-app bot merged commit 966fcc9 into main Aug 9, 2024
@graphite-app graphite-app bot deleted the 08-09-refactor_ast_codegen_re-order_code_in_fmt_module branch August 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants