-
-
Notifications
You must be signed in to change notification settings - Fork 778
refactor(ast_codegen): trim r# from start of field names
#4785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_codegen): trim r# from start of field names
#4785
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
7045345 to
b7f9308
Compare
30a0e0d to
8f24957
Compare
b7f9308 to
d074353
Compare
8f24957 to
b428568
Compare
CodSpeed Performance ReportMerging #4785 will not alter performanceComparing Summary
|
d074353 to
7ab0783
Compare
b428568 to
875a9cb
Compare
Merge activity
|
Some struct fields are reserved names e.g. `type`. They are written in source as `r#type`. Trim off the `r#` prefix in `FieldDef::name` and add it back when generating output. Main motivation is to have the unescaped field names in JSON schema.
7ab0783 to
3131187
Compare
875a9cb to
ec82a79
Compare

Some struct fields are reserved names e.g.
type. They are written in source asr#type. Trim off ther#prefix inFieldDef::nameand add it back when generating output.Main motivation is to have the unescaped field names in JSON schema.