Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 9, 2024

Some struct fields are reserved names e.g. type. They are written in source as r#type. Trim off the r# prefix in FieldDef::name and add it back when generating output.

Main motivation is to have the unescaped field names in JSON schema.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel marked this pull request as ready for review August 9, 2024 10:02
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from 7045345 to b7f9308 Compare August 9, 2024 10:10
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_trim_r_from_start_of_field_names branch from 30a0e0d to 8f24957 Compare August 9, 2024 10:11
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from b7f9308 to d074353 Compare August 9, 2024 10:14
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_trim_r_from_start_of_field_names branch from 8f24957 to b428568 Compare August 9, 2024 10:14
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #4785 will not alter performance

Comparing 08-09-refactor_ast_codegen_trim_r_from_start_of_field_names (ec82a79) with main (c79ca40)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel requested a review from rzvxa August 9, 2024 10:28
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from d074353 to 7ab0783 Compare August 9, 2024 10:29
@overlookmotel overlookmotel force-pushed the 08-09-refactor_ast_codegen_trim_r_from_start_of_field_names branch from b428568 to 875a9cb Compare August 9, 2024 10:30
@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Aug 9, 2024 — with Graphite App
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 9, 2024

Merge activity

Some struct fields are reserved names e.g. `type`. They are written in source as `r#type`. Trim off the `r#` prefix in `FieldDef::name` and add it back when generating output.

Main motivation is to have the unescaped field names in JSON schema.
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_alter_json_schema_format branch from 7ab0783 to 3131187 Compare August 9, 2024 10:52
@rzvxa rzvxa force-pushed the 08-09-refactor_ast_codegen_trim_r_from_start_of_field_names branch from 875a9cb to ec82a79 Compare August 9, 2024 10:53
Base automatically changed from 08-09-refactor_ast_codegen_alter_json_schema_format to main August 9, 2024 10:56
@graphite-app graphite-app bot merged commit ec82a79 into main Aug 9, 2024
@graphite-app graphite-app bot deleted the 08-09-refactor_ast_codegen_trim_r_from_start_of_field_names branch August 9, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants